Skip to content

[libc] Fix hdrgen output for no-argument functions #123245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frobtech merged 2 commits into from
Jan 17, 2025
Merged

[libc] Fix hdrgen output for no-argument functions #123245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de22bcc
[libc] Fix hdrgen output for no-argument functions
frobtech Jan 16, 2025
a05af56
Merge branch 'main' into p/libc-hdrgen-noargs
frobtech Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libc/utils/hdrgen/function.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ def __init__(

def __str__(self):
attributes_str = " ".join(self.attributes)
arguments_str = ", ".join(self.arguments)
arguments_str = ", ".join(self.arguments) if self.arguments else "void"
if attributes_str == "":
result = f"{self.return_type} {self.name}({arguments_str})"
else:
Expand Down
4 changes: 2 additions & 2 deletions libc/utils/hdrgen/tests/expected_output/test_header.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,10 @@ enum {

__BEGIN_C_DECLS

CONST_FUNC_A void func_a() __NOEXCEPT;
CONST_FUNC_A void func_a(void) __NOEXCEPT;

#ifdef LIBC_TYPES_HAS_FLOAT128
float128 func_b() __NOEXCEPT;
float128 func_b(void) __NOEXCEPT;
#endif // LIBC_TYPES_HAS_FLOAT128

#ifdef LIBC_TYPES_HAS_FLOAT16
Expand Down
Loading