Skip to content

[yaml2obj] Don't use uninitialized Type #123274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jan 23, 2025
Merged

[yaml2obj] Don't use uninitialized Type #123274

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
fbd205b
[𝘀𝗽𝗿] changes to main this commit is based on
vitalybuka Jan 17, 2025
fe815fa
[𝘀𝗽𝗿] initial version
vitalybuka Jan 17, 2025
877e727
[𝘀𝗽𝗿] changes introduced through rebase
JDevlieghere Jan 17, 2025
1576e59
fix
vitalybuka Jan 17, 2025
a1558db
error()
vitalybuka Jan 17, 2025
dc4d578
foramt
vitalybuka Jan 17, 2025
9dcd3ed
[𝘀𝗽𝗿] changes introduced through rebase
vitalybuka Jan 18, 2025
11cc681
update
vitalybuka Jan 18, 2025
94d1be7
update
vitalybuka Jan 18, 2025
b340b41
remove comment and move initialization
vitalybuka Jan 21, 2025
27918b2
comments
vitalybuka Jan 21, 2025
14fb5e4
test
vitalybuka Jan 21, 2025
36ce09c
rebase
vitalybuka Jan 21, 2025
cd55931
test comments
vitalybuka Jan 22, 2025
74f37d7
remove check line
vitalybuka Jan 22, 2025
95a6943
dedup
vitalybuka Jan 22, 2025
eb389d2
rebase
vitalybuka Jan 23, 2025
bc578af
nits
vitalybuka Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm/lib/ObjectYAML/ELFYAML.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1588,7 +1588,7 @@ static bool isInteger(StringRef Val) {

void MappingTraits<std::unique_ptr<ELFYAML::Chunk>>::mapping(
IO &IO, std::unique_ptr<ELFYAML::Chunk> &Section) {
ELFYAML::ELF_SHT Type;
ELFYAML::ELF_SHT Type = ELF::SHT_NULL;
StringRef TypeStr;
if (IO.outputting()) {
if (auto *S = dyn_cast<ELFYAML::Section>(Section.get()))
Expand Down
32 changes: 30 additions & 2 deletions llvm/test/tools/yaml2obj/ELF/section-type.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# RUN: yaml2obj %s -o %t
# RUN: llvm-readobj --sections %t | FileCheck %s
# RUN: yaml2obj %s --docnum=1 -o %t1
# RUN: llvm-readobj --sections %t1 | FileCheck %s

# CHECK: Name: enum
# CHECK: Type: SHT_PROGBITS
Expand All @@ -25,3 +25,31 @@ Sections:
Type: 0xabcd
- Name: decimal
Type: 1234


# RUN: not yaml2obj %s --docnum=2 -o %t2 2>&1 | FileCheck %s --check-prefix=UNKNOWN-TYPE

--- !ELF
FileHeader:
Class: ELFCLASS64
Data: ELFDATA2LSB
Type: ET_REL
Sections:
- Name: .foo
Type: FOO_SECTION

# UNKNOWN-TYPE: error: invalid hex32 number


# RUN: not yaml2obj %s --docnum=3 -o %t3 -DMACHINE=EM_NONE 2>&1 | FileCheck %s --check-prefix=UNKNOWN-SHT-TYPE

--- !ELF
FileHeader:
Class: ELFCLASS64
Data: ELFDATA2LSB
Type: ET_REL
Sections:
- Name: .foo
Type: SHT_MIPS_ABIFLAGS

# UNKNOWN-SHT-TYPE: error: invalid hex32 number
Loading