Skip to content

Conversation

@ita9naiwa
Copy link
Contributor

@ita9naiwa ita9naiwa commented Jan 21, 2025

Generalization.cpp:53

FailureOr<GenericOp> mlir::linalg::generalizeNamedOp(RewriterBase &rewriter,
                                                     LinalgOp linalgOp) {
  if (failed(generalizeNamedOpPrecondition(linalgOp)))
    return rewriter.notifyMatchFailure(linalgOp, "preconditions not met");

  SmallVector<Value> inputs = linalgOp.getDpsInputs();
  ValueRange outputs = linalgOp.getDpsInits();
  SmallVector<AffineMap> indexingMaps = linalgOp.getIndexingMapsArray();
  SmallVector<utils::IteratorType> iterators = linalgOp.getIteratorTypesArray();
  SmallVector<Type> resultTypes = linalgOp.hasPureTensorSemantics()
                                      ? TypeRange(ValueRange(outputs))
                                      : TypeRange{};
...

generalizeNamedOp in Generalization.cpp has a different arg name than generalizeNamedOp in Transforms.h

Sync to use linalgOp

implementation `generalizeNamedOp` in `Generalization.cpp` has different argname than `generalizeNamedOp` in `Transforms.h`
@llvmbot
Copy link
Member

llvmbot commented Jan 21, 2025

@llvm/pr-subscribers-mlir

@llvm/pr-subscribers-mlir-linalg

Author: Hyunsung Lee (ita9naiwa)

Changes

generalizeNamedOp in Generalization.cpp has a different arg name than generalizeNamedOp in Transforms.h

Sync to use linalgOp


Full diff: https://github.com/llvm/llvm-project/pull/123679.diff

1 Files Affected:

  • (modified) mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h (+3-3)
diff --git a/mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h b/mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h
index 1dc700f22c2027..c1b963cbe42b99 100644
--- a/mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h
+++ b/mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h
@@ -699,11 +699,11 @@ FailureOr<GenericOp> interchangeGenericOp(RewriterBase &rewriter,
                                           GenericOp genericOp,
                                           ArrayRef<unsigned> interchangeVector);
 
-/// Create a GenericOp from the given named operation `namedOp` and replace
-/// namedOp.
+/// Create a GenericOp from the given named operation `linalgOp` and replace
+/// the given `linalgOp`.
 /// Return failure if `namedOp` is a GenericOp or misses a region builder.
 FailureOr<GenericOp> generalizeNamedOp(RewriterBase &rewriter,
-                                       LinalgOp namedOp);
+                                       LinalgOp linalgOp);
 
 /// Create a namedOp from the given GenericOp and replace the GenericOp.
 /// Currently we can specialize only trivial linalg copy operations.

@ita9naiwa ita9naiwa changed the title Update arg name of generalizeNamedOp in Transforms.h [MLIR/linalg] Update arg name of generalizeNamedOp in Transforms.h Jan 21, 2025
@rengolin
Copy link
Member

@ita9naiwa do you have merge access?

@ita9naiwa
Copy link
Contributor Author

@rengolin no, could you merge this please?

@rengolin rengolin merged commit 83cdcd5 into llvm:main Jan 21, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants