From 4984f8d2d37168ea433763dbd9adfe96054f889f Mon Sep 17 00:00:00 2001 From: Hyunsung Lee Date: Tue, 21 Jan 2025 12:08:28 +0900 Subject: [PATCH 1/2] Update argment name of `generalizeNamedOp` in `Transforms.h` implementation `generalizeNamedOp` in `Generalization.cpp` has different argname than `generalizeNamedOp` in `Transforms.h` --- mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h b/mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h index 1dc700f22c202..c1b963cbe42b9 100644 --- a/mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h +++ b/mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h @@ -699,11 +699,11 @@ FailureOr interchangeGenericOp(RewriterBase &rewriter, GenericOp genericOp, ArrayRef interchangeVector); -/// Create a GenericOp from the given named operation `namedOp` and replace -/// namedOp. +/// Create a GenericOp from the given named operation `linalgOp` and replace +/// the given `linalgOp`. /// Return failure if `namedOp` is a GenericOp or misses a region builder. FailureOr generalizeNamedOp(RewriterBase &rewriter, - LinalgOp namedOp); + LinalgOp linalgOp); /// Create a namedOp from the given GenericOp and replace the GenericOp. /// Currently we can specialize only trivial linalg copy operations. From a5ef32cf1b214e1cc056dd5d82cfff15a883a388 Mon Sep 17 00:00:00 2001 From: Hyunsung Lee Date: Tue, 21 Jan 2025 20:34:02 +0900 Subject: [PATCH 2/2] Update Transforms.h --- mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h b/mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h index c1b963cbe42b9..eed279b6be34a 100644 --- a/mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h +++ b/mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h @@ -701,7 +701,7 @@ FailureOr interchangeGenericOp(RewriterBase &rewriter, /// Create a GenericOp from the given named operation `linalgOp` and replace /// the given `linalgOp`. -/// Return failure if `namedOp` is a GenericOp or misses a region builder. +/// Return failure if `linalgOp` is a GenericOp or misses a region builder. FailureOr generalizeNamedOp(RewriterBase &rewriter, LinalgOp linalgOp);