[llvm][Object] Add missing const qualifier for value_type in content_iterator #124106
Conversation
…iterator. value_type was defined as non-const for content_iterator, although it's methods returned a const pointers/references. This prevented it from using in some algorithms from STLExtras.h
|
@llvm/pr-subscribers-llvm-binary-utilities Author: Bushev Dmitry (dybv-sc) Changesvalue_type was defined as non-const for content_iterator, although it's methods returned a const pointers/references. This prevented it from using in some algorithms from STLExtras.h Full diff: https://github.com/llvm/llvm-project/pull/124106.diff 1 Files Affected:
diff --git a/llvm/include/llvm/Object/SymbolicFile.h b/llvm/include/llvm/Object/SymbolicFile.h
index b13588c147d9b2..2c857e72c3e5a6 100644
--- a/llvm/include/llvm/Object/SymbolicFile.h
+++ b/llvm/include/llvm/Object/SymbolicFile.h
@@ -71,7 +71,7 @@ template <class content_type> class content_iterator {
public:
using iterator_category = std::forward_iterator_tag;
- using value_type = content_type;
+ using value_type = const content_type;
using difference_type = std::ptrdiff_t;
using pointer = value_type *;
using reference = value_type &;
|
@kuhar, sure, added unit test |
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
dybv-sc
force-pushed
the
object-iterator-const-missing-fix
branch
from
790e62b to
27d2197
Compare
| #include "llvm/ADT/STLExtras.h" | ||
| #include "llvm/Support/raw_ostream.h" | ||
| #include "llvm/TargetParser/Host.h" | ||
|
|
There was a problem hiding this comment.
Please remove this blank line. Headers should be included as one contiguous block, otherwise clang-format won't sort them properly.
|
@dybv-sc I think this PR have collected enough feedback, let's resolve review comments, thanks! |
jh7370
left a comment
jh7370
left a comment
There was a problem hiding this comment.
No more comments from me. Happy once others are.
5 participants
value_type was defined as non-const for content_iterator, although it's methods returned a const pointers/references. This prevented it from using in some algorithms from STLExtras.h