Skip to content

Conversation

@michaelmaitland
Copy link
Contributor

I was studying the code here and realized that the comments were talking about grouping by basic blocks when the code was grouping by Function. Fix the comments so they reflect what the code is actually doing.

@michaelmaitland michaelmaitland changed the title [GlobalMerge][NFC] Fix inaccurate comment [GlobalMerge][NFC] Fix inaccurate comments Jan 23, 2025
I was studying the code here and realized that the comments were talking about
grouping by basic blocks when the code was grouping by Function. Fix the
comments so they reflect what the code is actually doing.
Copy link
Collaborator

@topperc topperc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelmaitland michaelmaitland merged commit 7db4ba3 into llvm:main Jan 23, 2025
5 of 6 checks passed
@michaelmaitland michaelmaitland deleted the fix-comment-gm branch January 23, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants