Skip to content

[SandboxVec][Scheduler] Fix clear() to clear all state #124214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vporpo merged 1 commit into from
Jan 24, 2025
Merged

[SandboxVec][Scheduler] Fix clear() to clear all state #124214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions llvm/include/llvm/Transforms/Vectorize/SandboxVectorizer/DependencyGraph.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,13 @@ class DependencyGraph {
DAGInterval = {};
}
#ifndef NDEBUG
/// \Returns true if the DAG's state is clear. Used in assertions.
bool empty() const {
bool IsEmpty = InstrToNodeMap.empty();
assert(IsEmpty == DAGInterval.empty() &&
"Interval and InstrToNodeMap out of sync!");
return IsEmpty;
}
void print(raw_ostream &OS) const;
LLVM_DUMP_METHOD void dump() const;
#endif // NDEBUG
Expand Down
3 changes: 3 additions & 0 deletions llvm/include/llvm/Transforms/Vectorize/SandboxVectorizer/Scheduler.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,10 @@ class Scheduler {
Bndls.clear();
// TODO: clear view once it lands.
DAG.clear();
ReadyList.clear();
ScheduleTopItOpt = std::nullopt;
assert(Bndls.empty() && DAG.empty() && ReadyList.empty() &&
!ScheduleTopItOpt && "Expected empty state!");
}

#ifndef NDEBUG
Expand Down
Loading