Skip to content

[AArch64] Fix movk parsing with an .equ operand #124428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 26, 2025
Merged

[AArch64] Fix movk parsing with an .equ operand #124428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b772fb
Fix movk on aarch64 with an .equ operand
Jan 25, 2025
e93b820
Move test to basic-a64-instructions.s
Jan 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5017,7 +5017,9 @@ bool AArch64AsmParser::parseOperand(OperandVector &Operands, bool isCondCode,
return true;
E = SMLoc::getFromPointer(getLoc().getPointer() - 1);
Operands.push_back(AArch64Operand::CreateImm(IdVal, S, E, getContext()));
return false;

// Parse an optional shift/extend modifier.
return parseOptionalShiftExtend(getTok());
}
case AsmToken::Integer:
case AsmToken::Real:
Expand Down
5 changes: 5 additions & 0 deletions llvm/test/MC/AArch64/basic-a64-instructions.s
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3347,6 +3347,11 @@ _func:
// CHECK: mov x2, #5299989643264 // encoding: [0x42,0x9a,0xc0,0xd2]
// CHECK: movk xzr, #{{4321|0x10e1}}, lsl #48 // encoding: [0x3f,0x1c,0xe2,0xf2]

.equ equvalue, 0x0001
movk x1, equvalue, lsl 16
// CHECK: .set equvalue, 1
// CHECK-NEXT: movk x1, #1, lsl #16 // encoding: [0x21,0x00,0xa0,0xf2]

movz x2, #:abs_g0:sym
movk w3, #:abs_g0_nc:sym

Expand Down
Loading