Skip to content

[TableGen] Avoid repeated map lookups (NFC) #124448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 26, 2025
Merged

[TableGen] Avoid repeated map lookups (NFC) #124448

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2273e9e
[TableGen] Avoid repeated map lookups (NFC)
kazutakahirata Jan 26, 2025
8265a5f
Address comments.
kazutakahirata Jan 26, 2025
f6bd25b
Remove an unused include.
kazutakahirata Jan 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions clang/utils/TableGen/MveEmitter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@

#include "llvm/ADT/APInt.h"
#include "llvm/ADT/StringRef.h"
#include "llvm/ADT/StringSet.h"
#include "llvm/ADT/StringSwitch.h"
#include "llvm/Support/Casting.h"
#include "llvm/Support/raw_ostream.h"
Expand Down Expand Up @@ -1955,18 +1956,17 @@ void MveEmitter::EmitBuiltinDef(raw_ostream &OS) {
<< ", \"\", \"n\")\n";
}

std::set<std::string> ShortNamesSeen;
StringSet<> ShortNamesSeen;

for (const auto &kv : ACLEIntrinsics) {
const ACLEIntrinsic &Int = *kv.second;
if (Int.polymorphic()) {
StringRef Name = Int.shortName();
if (ShortNamesSeen.find(std::string(Name)) == ShortNamesSeen.end()) {
if (ShortNamesSeen.insert(Name).second) {
OS << "BUILTIN(__builtin_arm_mve_" << Name << ", \"vi.\", \"nt";
if (Int.nonEvaluating())
OS << "u"; // indicate that this builtin doesn't evaluate its args
OS << "\")\n";
ShortNamesSeen.insert(std::string(Name));
}
}
}
Expand Down
Loading