Skip to content

[clang][CodeComplete] Use HeuristicResolver to resolve CXXDependentScopeMemberExpr #124449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HighCommander4 wants to merge 1 commit into from
Closed

[clang][CodeComplete] Use HeuristicResolver to resolve CXXDependentScopeMemberExpr #124449

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 4 additions & 17 deletions clang/lib/Sema/SemaCodeComplete.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5796,24 +5796,11 @@ QualType getApproximateType(const Expr *E, HeuristicResolver &Resolver) {
return QualType(Common, 0);
}
}
// A dependent member: approximate-resolve the base, then lookup.
// A dependent member: resolve using HeuristicResolver.
if (const auto *CDSME = llvm::dyn_cast<CXXDependentScopeMemberExpr>(E)) {
QualType Base = CDSME->isImplicitAccess()
? CDSME->getBaseType()
: getApproximateType(CDSME->getBase(), Resolver);
if (CDSME->isArrow() && !Base.isNull())
Base = Base->getPointeeType(); // could handle unique_ptr etc here?
auto *RD =
Base.isNull()
? nullptr
: llvm::dyn_cast_or_null<CXXRecordDecl>(getAsRecordDecl(Base));
if (RD && RD->isCompleteDefinition()) {
// Look up member heuristically, including in bases.
for (const auto *Member : RD->lookupDependentName(
CDSME->getMember(), [](const NamedDecl *Member) {
return llvm::isa<ValueDecl>(Member);
})) {
return llvm::cast<ValueDecl>(Member)->getType().getNonReferenceType();
for (const auto *Member : Resolver.resolveMemberExpr(CDSME)) {
if (const auto *VD = dyn_cast<ValueDecl>(Member)) {
return VD->getType().getNonReferenceType();
}
}
}
Expand Down
Loading