Skip to content

Conversation

@vova7878
Copy link
Contributor

enum LLVMLandingPadClauseTy has never been used and exists by mistake.

This commit added a LLVMAddClause function that took it as a parameter.

Here the enum was removed.

And here it is added again by mistake, although the LLVMAddClause function no longer accepts it

@github-actions
Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@vova7878
Copy link
Contributor Author

vova7878 commented Feb 2, 2025

Ping

Copy link
Member

@junlarsen junlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me

@junlarsen
Copy link
Member

Test failures seem unrelated. Do you need me to merge the patch on your behalf?

@vova7878
Copy link
Contributor Author

vova7878 commented Feb 2, 2025

Test failures seem unrelated. Do you need me to merge the patch on your behalf?

I would be glad if you did that. Thank you.

@junlarsen junlarsen merged commit 2cac0bf into llvm:main Feb 2, 2025
5 of 7 checks passed
@github-actions
Copy link

github-actions bot commented Feb 2, 2025

@vova7878 Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants