[lldb] Remove PATH workaround for Android

[brad0]

No description provided.

[llvmbot]

@llvm/pr-subscribers-lldb

Author: Brad Smith (brad0)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/124682.diff

1 Files Affected:

• (modified) lldb/source/Host/posix/ProcessLauncherPosixFork.cpp (-6)

diff --git a/lldb/source/Host/posix/ProcessLauncherPosixFork.cpp b/lldb/source/Host/posix/ProcessLauncherPosixFork.cpp
index 7d856954684c49..f983305f3f3919 100644
--- a/lldb/source/Host/posix/ProcessLauncherPosixFork.cpp
+++ b/lldb/source/Host/posix/ProcessLauncherPosixFork.cpp
@@ -231,12 +231,6 @@ MakeForkActions(const ProcessLaunchInfo &info) {
 }
 
 static Environment::Envp FixupEnvironment(Environment env) {
-#ifdef __ANDROID__
-  // If there is no PATH variable specified inside the environment then set the
-  // path to /system/bin. It is required because the default path used by
-  // execve() is wrong on android.
-  env.try_emplace("PATH", "/system/bin");
-#endif
   return env.getEnvp();
 }
 

[labath]

Let's delete the FixupEnvironment function as well (replace it with a direct env.getEnvp() call) -- it only exists to hide the android hack.

[enh-google]

Let's delete the FixupEnvironment function as well (replace it with a direct env.getEnvp() call) -- it only exists to hide the android hack.

+1 --- seems weird to say "fix up" when doing nothing. otherwise lgtm...

[github-actions]

✅ With the latest revision this PR passed the C/C++ code formatter.