Skip to content

[lldb][test] Add test for detecting CV-quals of explicit object member functions #125053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 30, 2025
Merged

[lldb][test] Add test for detecting CV-quals of explicit object member functions #125053

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
310d7d6
[lldb][test] Add test for detecting CV-quals of explicit object membe…
Michael137 Jan 30, 2025
27405d6
fixup! clang-format
Michael137 Jan 30, 2025
c0c2ba1
fixup! specify triple explicitly
Michael137 Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions lldb/test/Shell/SymbolFile/DWARF/explicit-member-function-quals.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
// XFAIL: *

// Tests that we correctly deduce the CV-quals and storage
// class of explicit object member functions.
//
// RUN: %clangxx_host %s -g -std=c++23 -c -o %t
Copy link
Collaborator

@labath labath Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need -gdwarf to produce dwarf on windows. But maybe it's better to hardcode your favourite triple for reproducibility?

// RUN: %lldb %t -b -o "type lookup Foo" 2>&1 | FileCheck %s
//
// CHECK: (lldb) type lookup Foo
// CHECK-NEXT: struct Foo {
// CHECK-NEXT: void Method(Foo);
// CHECK-NEXT: void cMethod(Foo const&);
// CHECK-NEXT: void vMethod(Foo volatile&);
// CHECK-NEXT: void cvMethod(const Foo volatile&) const volatile;
Copy link
Member Author

@Michael137 Michael137 Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The representation here doesn't look right also. But that's a separate bug probably with the AST that LLDB creates

// CHECK-NEXT: }

struct Foo {
void Method(this Foo) {}
void cMethod(this Foo const &) {}
void vMethod(this Foo volatile &) {}
void cvMethod(this Foo const volatile &) {}
} f;