From 4bf34a5278164fd96158a197fbadb8422453dd45 Mon Sep 17 00:00:00 2001 From: Craig Topper Date: Thu, 30 Jan 2025 15:35:47 -0800 Subject: [PATCH 1/2] [RISCV][VLOpt] Move OperandInfo into anonymous namespace. Move getEMULEqualsEEWDivSEWTimesLMUL out of RISCVVType namespace. NFC We don't want OperandInfo to be visible outside of this object. getEMULEqualsEEWDivSEWTimesLMUL is local to this file and declared static there's no reason to put it in a namespace. --- llvm/lib/Target/RISCV/RISCVVLOptimizer.cpp | 44 ++++++++++------------ 1 file changed, 20 insertions(+), 24 deletions(-) diff --git a/llvm/lib/Target/RISCV/RISCVVLOptimizer.cpp b/llvm/lib/Target/RISCV/RISCVVLOptimizer.cpp index cd866f04af20e..3f3f396ec8595 100644 --- a/llvm/lib/Target/RISCV/RISCVVLOptimizer.cpp +++ b/llvm/lib/Target/RISCV/RISCVVLOptimizer.cpp @@ -62,25 +62,6 @@ class RISCVVLOptimizer : public MachineFunctionPass { DenseMap> DemandedVLs; }; -} // end anonymous namespace - -char RISCVVLOptimizer::ID = 0; -INITIALIZE_PASS_BEGIN(RISCVVLOptimizer, DEBUG_TYPE, PASS_NAME, false, false) -INITIALIZE_PASS_DEPENDENCY(MachineDominatorTreeWrapperPass) -INITIALIZE_PASS_END(RISCVVLOptimizer, DEBUG_TYPE, PASS_NAME, false, false) - -FunctionPass *llvm::createRISCVVLOptimizerPass() { - return new RISCVVLOptimizer(); -} - -/// Return true if R is a physical or virtual vector register, false otherwise. -static bool isVectorRegClass(Register R, const MachineRegisterInfo *MRI) { - if (R.isPhysical()) - return RISCV::VRRegClass.contains(R); - const TargetRegisterClass *RC = MRI->getRegClass(R); - return RISCVRI::isVRegClass(RC->TSFlags); -} - /// Represents the EMUL and EEW of a MachineOperand. struct OperandInfo { // Represent as 1,2,4,8, ... and fractional indicator. This is because @@ -121,6 +102,25 @@ struct OperandInfo { } }; +} // end anonymous namespace + +char RISCVVLOptimizer::ID = 0; +INITIALIZE_PASS_BEGIN(RISCVVLOptimizer, DEBUG_TYPE, PASS_NAME, false, false) +INITIALIZE_PASS_DEPENDENCY(MachineDominatorTreeWrapperPass) +INITIALIZE_PASS_END(RISCVVLOptimizer, DEBUG_TYPE, PASS_NAME, false, false) + +FunctionPass *llvm::createRISCVVLOptimizerPass() { + return new RISCVVLOptimizer(); +} + +/// Return true if R is a physical or virtual vector register, false otherwise. +static bool isVectorRegClass(Register R, const MachineRegisterInfo *MRI) { + if (R.isPhysical()) + return RISCV::VRRegClass.contains(R); + const TargetRegisterClass *RC = MRI->getRegClass(R); + return RISCVRI::isVRegClass(RC->TSFlags); +} + LLVM_ATTRIBUTE_UNUSED static raw_ostream &operator<<(raw_ostream &OS, const OperandInfo &OI) { OI.print(OS); @@ -137,8 +137,6 @@ static raw_ostream &operator<<(raw_ostream &OS, return OS; } -namespace llvm { -namespace RISCVVType { /// Return EMUL = (EEW / SEW) * LMUL where EEW comes from Log2EEW and LMUL and /// SEW are from the TSFlags of MI. static std::pair @@ -165,8 +163,6 @@ getEMULEqualsEEWDivSEWTimesLMUL(unsigned Log2EEW, const MachineInstr &MI) { Denom = MILMULIsFractional ? Denom * MILMUL / GCD : Denom / GCD; return std::make_pair(Num > Denom ? Num : Denom, Denom > Num); } -} // end namespace RISCVVType -} // end namespace llvm /// Dest has EEW=SEW. Source EEW=SEW/Factor (i.e. F2 => EEW/2). /// SEW comes from TSFlags of MI. @@ -770,7 +766,7 @@ getOperandInfo(const MachineOperand &MO, const MachineRegisterInfo *MRI) { }; // All others have EMUL=EEW/SEW*LMUL - return OperandInfo(RISCVVType::getEMULEqualsEEWDivSEWTimesLMUL(*Log2EEW, MI), + return OperandInfo(getEMULEqualsEEWDivSEWTimesLMUL(*Log2EEW, MI), *Log2EEW); } From 31fdf2057ae4e18a3a56615634fbbd6402bbaf66 Mon Sep 17 00:00:00 2001 From: Craig Topper Date: Thu, 30 Jan 2025 15:42:21 -0800 Subject: [PATCH 2/2] fixup! clang-format --- llvm/lib/Target/RISCV/RISCVVLOptimizer.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/llvm/lib/Target/RISCV/RISCVVLOptimizer.cpp b/llvm/lib/Target/RISCV/RISCVVLOptimizer.cpp index 3f3f396ec8595..4516d662bc779 100644 --- a/llvm/lib/Target/RISCV/RISCVVLOptimizer.cpp +++ b/llvm/lib/Target/RISCV/RISCVVLOptimizer.cpp @@ -766,8 +766,7 @@ getOperandInfo(const MachineOperand &MO, const MachineRegisterInfo *MRI) { }; // All others have EMUL=EEW/SEW*LMUL - return OperandInfo(getEMULEqualsEEWDivSEWTimesLMUL(*Log2EEW, MI), - *Log2EEW); + return OperandInfo(getEMULEqualsEEWDivSEWTimesLMUL(*Log2EEW, MI), *Log2EEW); } /// Return true if this optimization should consider MI for VL reduction. This