diff --git a/llvm/utils/TableGen/DAGISelMatcherOpt.cpp b/llvm/utils/TableGen/DAGISelMatcherOpt.cpp index f747944543cfd..62d6038e580f7 100644 --- a/llvm/utils/TableGen/DAGISelMatcherOpt.cpp +++ b/llvm/utils/TableGen/DAGISelMatcherOpt.cpp @@ -191,7 +191,9 @@ static Matcher *FindNodeWithKind(Matcher *M, Matcher::KindTy Kind) { return nullptr; } -/// FactorNodes - Turn matches like this: +static void FactorNodes(std::unique_ptr &InputMatcherPtr); + +/// Turn matches like this: /// Scope /// OPC_CheckType i32 /// ABC @@ -203,22 +205,8 @@ static Matcher *FindNodeWithKind(Matcher *M, Matcher::KindTy Kind) { /// ABC /// XYZ /// -static void FactorNodes(std::unique_ptr &InputMatcherPtr) { - // Look for a push node. Iterates instead of recurses to reduce stack usage. - ScopeMatcher *Scope = nullptr; - std::unique_ptr *RebindableMatcherPtr = &InputMatcherPtr; - while (!Scope) { - // If we reached the end of the chain, we're done. - Matcher *N = RebindableMatcherPtr->get(); - if (!N) - return; - - // If this is not a push node, just scan for one. - Scope = dyn_cast(N); - if (!Scope) - RebindableMatcherPtr = &(N->getNextPtr()); - } - std::unique_ptr &MatcherPtr = *RebindableMatcherPtr; +static void FactorScope(std::unique_ptr &MatcherPtr) { + ScopeMatcher *Scope = cast(MatcherPtr.get()); // Okay, pull together the children of the scope node into a vector so we can // inspect it more easily. @@ -353,7 +341,7 @@ static void FactorNodes(std::unique_ptr &InputMatcherPtr) { Shared->setNext(new ScopeMatcher(std::move(EqualMatchers))); // Recursively factor the newly created node. - FactorNodes(Shared->getNextPtr()); + FactorScope(Shared->getNextPtr()); } // Put the new Matcher where we started in OptionsToMatch. @@ -470,7 +458,7 @@ static void FactorNodes(std::unique_ptr &InputMatcherPtr) { for (auto &M : Cases) { if (ScopeMatcher *SM = dyn_cast(M.second)) { std::unique_ptr Scope(SM); - FactorNodes(Scope); + FactorScope(Scope); M.second = Scope.release(); assert(M.second && "null matcher"); } @@ -492,6 +480,20 @@ static void FactorNodes(std::unique_ptr &InputMatcherPtr) { Scope->resetChild(i, OptionsToMatch[i]); } +/// Search a ScopeMatcher to factor with FactorScope. +static void FactorNodes(std::unique_ptr &InputMatcherPtr) { + // Look for a scope matcher. Iterates instead of recurses to reduce stack + // usage. + std::unique_ptr *MatcherPtr = &InputMatcherPtr; + do { + if (isa(*MatcherPtr)) + return FactorScope(*MatcherPtr); + + // If this is not a scope matcher, go to the next node. + MatcherPtr = &(MatcherPtr->get()->getNextPtr()); + } while (MatcherPtr->get()); +} + void llvm::OptimizeMatcher(std::unique_ptr &MatcherPtr, const CodeGenDAGPatterns &CGP) { ContractNodes(MatcherPtr, CGP);