Skip to content

[MC/DC] Update CoverageMapping tests #125404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chapuni merged 2 commits into from
Mar 1, 2025
Merged

[MC/DC] Update CoverageMapping tests #125404

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6d4be0
[MC/DC] Update CoverageMapping tests
chapuni Feb 2, 2025
8b35e76
Remove mcdc-single-cond.cpp
chapuni Mar 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions clang/test/CoverageMapping/mcdc-error-nests.cpp
View file
Open in desktop

This file was deleted.

34 changes: 34 additions & 0 deletions clang/test/CoverageMapping/mcdc-nested-expr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
// RUN: %clang_cc1 -triple %itanium_abi_triple -std=c++11 -fcoverage-mcdc -fprofile-instrument=clang -fcoverage-mapping -dump-coverage-mapping -emit-llvm-only %s 2> %t.stderr.txt | FileCheck %s
// RUN: FileCheck %s --check-prefix=WARN < %t.stderr.txt

// "Split-nest" -- boolean expressions within boolean expressions.
extern bool bar(bool);
// CHECK: func_split_nest{{.*}}:
bool func_split_nest(bool a, bool b, bool c, bool d, bool e, bool f, bool g) {
// WARN: :[[@LINE+1]]:14: warning: unsupported MC/DC boolean expression; contains an operation with a nested boolean expression.
bool res = a && b && c && bar(d && e) && f && g;
return bar(res);
}

// The inner expr begins with the same Loc as the outer expr
// CHECK: func_condop{{.*}}:
bool func_condop(bool a, bool b, bool c) {
// WARN: :[[@LINE+1]]:10: warning: unsupported MC/DC boolean expression; contains an operation with a nested boolean expression.
return (a && b ? true : false) && c;
}

// __builtin_expect
// Treated as parentheses.
// CHECK: func_expect{{.*}}:
bool func_expect(bool a, bool b, bool c) {
// WARN: :[[@LINE+1]]:10: warning: unsupported MC/DC boolean expression; contains an operation with a nested boolean expression.
return a || __builtin_expect(b && c, true);
}

// LNot among BinOp(s)
// Doesn't split exprs.
// CHECK: func_lnot{{.*}}:
bool func_lnot(bool a, bool b, bool c, bool d) {
// WARN: :[[@LINE+1]]:10: warning: unsupported MC/DC boolean expression; contains an operation with a nested boolean expression.
return !(a || b) && !(c && d);
}
97 changes: 97 additions & 0 deletions clang/test/CoverageMapping/mcdc-single-cond.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,97 @@
// RUN: %clang_cc1 -triple %itanium_abi_triple -std=c++11 -fcoverage-mcdc -fprofile-instrument=clang -fcoverage-mapping -dump-coverage-mapping -disable-llvm-passes -emit-llvm -o %t2.ll %s | FileCheck %s --check-prefixes=MM,MM2
// RUN: FileCheck %s --check-prefixes=LL,LL2 < %t2.ll

// LL: define{{.+}}func_cond{{.+}}(
// MM: func_cond{{.*}}:
int func_cond(bool a, bool b) {
// %mcdc.addr* are emitted by static order.
// LL: %[[MA:mcdc.addr.*]] = alloca i32, align 4
// LL: call void @llvm.instrprof.mcdc.parameters(ptr @[[PROFN:.+]], i64 [[#H:]], i32 [[#BS:]])
int count = 0;
if (a)
// NB=2 Single cond
// MM2-NOT: Decision
++count;
if (a ? true : false)
// NB=2,2 Wider decision comes first.
// MA2 has C:2
// MA3 has C:1
++count;
if (a && b ? true : false)
// NB=2,3 Wider decision comes first.
// MM2: Decision,File 0, [[@LINE-2]]:7 -> [[#L:@LINE-2]]:13 = M:[[#I:3]], C:2
// MM: Branch,File 0, [[#L]]:7 -> [[#L]]:8 = #6, (#0 - #6) [1,2,0]
// MM: Branch,File 0, [[#L]]:12 -> [[#L]]:13 = #7, (#6 - #7) [2,0,0]
// LL: store i32 0, ptr %[[MA]], align 4
// LL: = load i32, ptr %[[MA]], align 4
// LL: store i32 %{{.+}}, ptr %[[MA]], align 4
// LL: = load i32, ptr %[[MA]], align 4
// LL: store i32 %{{.+}}, ptr %[[MA]], align 4
// LL2: call void @llvm.instrprof.mcdc.tvbitmap.update(ptr @[[PROFN]], i64 [[#H]], i32 [[#B:0]], ptr %[[MA]])
++count;
while (a || true) {
// NB=3 BinOp only
// MM: Decision,File 0, [[@LINE-2]]:10 -> [[#L:@LINE-2]]:19 = M:[[#I:I+3]], C:2
// MM: Branch,File 0, [[#L]]:10 -> [[#L]]:11 = (#0 - #9), #9 [1,0,2]
// MM: Branch,File 0, [[#L]]:15 -> [[#L]]:19 = (#9 - #10), 0 [2,0,0]
// LL: store i32 0, ptr %[[MA]], align 4
// LL: = load i32, ptr %[[MA]], align 4
// LL: store i32 %{{.+}}, ptr %[[MA]], align 4
// LL: = load i32, ptr %[[MA]], align 4
// LL: store i32 %{{.+}}, ptr %[[MA]], align 4
// LL2: call void @llvm.instrprof.mcdc.tvbitmap.update(ptr @[[PROFN]], i64 [[#H]], i32 [[#B:B+3]], ptr %[[MA]])
++count;
break;
}
while (a || true ? false : true) {
// Wider decision comes first.
// MM2: Decision,File 0, [[@LINE-2]]:10 -> [[#L:@LINE-2]]:19 = M:[[#I:I+3]], C:2
// MM: Branch,File 0, [[#L]]:10 -> [[#L]]:11 = ((#0 + #11) - #13), #13 [1,0,2]
// MM: Branch,File 0, [[#L]]:15 -> [[#L]]:19 = (#13 - #14), 0 [2,0,0]
// LL: store i32 0, ptr %[[MA]], align 4
// LL: = load i32, ptr %[[MA]], align 4
// LL: store i32 %{{.+}}, ptr %[[MA]], align 4
// LL: = load i32, ptr %[[MA]], align 4
// LL: store i32 %{{.+}}, ptr %[[MA]], align 4
// LL: call void @llvm.instrprof.mcdc.tvbitmap.update(ptr @[[PROFN]], i64 [[#H]], i32 [[#B:B+3]], ptr %[[MA]])
++count;
}
do {
++count;
} while (a && false);
// BinOp only
// MM: Decision,File 0, [[@LINE-2]]:12 -> [[#L:@LINE-2]]:22 = M:[[#I:I+3]], C:2
// MM: Branch,File 0, [[#L]]:12 -> [[#L]]:13 = #16, ((#0 + #15) - #16) [1,2,0]
// MM: Branch,File 0, [[#L]]:17 -> [[#L]]:22 = 0, (#16 - #17) [2,0,0]
// LL: store i32 0, ptr %[[MA]], align 4
// LL: = load i32, ptr %[[MA]], align 4
// LL: store i32 %{{.+}}, ptr %[[MA]], align 4
// LL: = load i32, ptr %[[MA]], align 4
// LL: store i32 %{{.+}}, ptr %[[MA]], align 4
// LL2: call void @llvm.instrprof.mcdc.tvbitmap.update(ptr @[[PROFN]], i64 [[#H]], i32 [[#B:B+3]], ptr %[[MA]])
do {
++count;
} while (a && false ? true : false);
// Wider decision comes first.
// MM2: Decision,File 0, [[@LINE-2]]:12 -> [[#L:@LINE-2]]:22 = M:15, C:2
// MM: Branch,File 0, [[#L]]:12 -> [[#L]]:13 = #20, ((#0 + #18) - #20) [1,2,0]
// MM: Branch,File 0, [[#L]]:17 -> [[#L]]:22 = 0, (#20 - #21) [2,0,0]
// LL: store i32 0, ptr %[[MA]], align 4
// LL: = load i32, ptr %[[MA]], align 4
// LL: store i32 %{{.+}}, ptr %[[MA]], align 4
// LL: = load i32, ptr %[[MA]], align 4
// LL: store i32 %{{.+}}, ptr %[[MA]], align 4
// LL: call void @llvm.instrprof.mcdc.tvbitmap.update(ptr @[[PROFN]], i64 [[#H]], i32 [[#B:B+3]], ptr %[[MA]])
// FIXME: Confirm (B+3==BS)
for (int i = 0; i < (a ? 2 : 1); ++i) {
// Simple nested decision (different column)
// MM2-NOT: Decision
// LL2-NOT: call void @llvm.instrprof.mcdc.tvbitmap.update
++count;
}
for (int i = 0; i >= 4 ? false : true; ++i) {
// Wider decision comes first.
++count;
}
return count;
}