Skip to content

Conversation

@tgross35
Copy link
Contributor

@tgross35 tgross35 commented Feb 3, 2025

Langref for roundeven implies that the C standard function roundeven may raise floating point exceptions. However, this is not correct; C23 does not mention exceptions for roundeven, and per 1 FE_INEXACT is never raised.

Clarify that LLVM's roundeven behaves the same.

@github-actions
Copy link

github-actions bot commented Feb 3, 2025

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvmbot llvmbot added the llvm:ir label Feb 3, 2025
@llvmbot
Copy link
Member

llvmbot commented Feb 3, 2025

@llvm/pr-subscribers-llvm-ir

Author: Trevor Gross (tgross35)

Changes

Langref for roundeven implies that the C standard function roundeven may raise floating point exceptions. However, this is not correct; C23 does not mention exceptions for roundeven, and per 1 FE_INEXACT is never raised.

Clarify that LLVM's roundeven behaves the same.


Full diff: https://github.com/llvm/llvm-project/pull/125452.diff

1 Files Affected:

  • (modified) llvm/docs/LangRef.rst (+2-2)
diff --git a/llvm/docs/LangRef.rst b/llvm/docs/LangRef.rst
index 8891aedcb58e55..bd9c522987834f 100644
--- a/llvm/docs/LangRef.rst
+++ b/llvm/docs/LangRef.rst
@@ -17255,8 +17255,8 @@ Semantics:
 """"""""""
 
 This function implements IEEE-754 operation ``roundToIntegralTiesToEven``. It
-also behaves in the same way as C standard function ``roundeven``, except that
-it does not raise floating point exceptions.
+also behaves in the same way as C standard function ``roundeven``, including
+that it disregards rounding mode and does not raise floating point exceptions.
 
 
 '``llvm.lround.*``' Intrinsic

@tgross35 tgross35 changed the title Correct documentation for roundeven [LangRef] Correct documentation for roundeven Feb 3, 2025
Langref for `roundeven` implies that the C standard function `roundeven`
may raise floating point exceptions. However, this is not correct; C23
does not mention exceptions for `roundeven`, and per [1] `FE_INEXACT` is
never raised.

Clarify that LLVM's `roundeven` behaves the same.

[1]: https://en.cppreference.com/w/c/numeric/math/roundeven
@tgross35
Copy link
Contributor Author

tgross35 commented Mar 1, 2025

@arsenm it looks like you have reviewed some of the sections around here, would you mind taking a look at this?

@arsenm arsenm added the floating-point Floating-point math label Mar 1, 2025
@arsenm arsenm merged commit 84b365c into llvm:main Mar 1, 2025
8 checks passed
@github-actions
Copy link

github-actions bot commented Mar 1, 2025

@tgross35 Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

@tgross35
Copy link
Contributor Author

tgross35 commented Mar 1, 2025

Thanks!

@tgross35 tgross35 deleted the langref-roundeven branch March 1, 2025 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

floating-point Floating-point math llvm:ir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants