[MLIR] Remove unnecessary include from MathToEmitC.h to fix build issue #125466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-mlir-emitc @llvm/pr-subscribers-mlir Author: Tomer Solomon (recursion-man) ChangesThis removes the unnecessary inclusion of mlir/Dialect/EmitC/IR/EmitC.h from MathToEmitC.h, which caused a build failure due to a missing EmitCEnums.h.inc. The include was not needed, and removing it resolves the issue without requiring additional dependencies. Full diff: https://github.com/llvm/llvm-project/pull/125466.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Conversion/MathToEmitC/MathToEmitC.h b/mlir/include/mlir/Conversion/MathToEmitC/MathToEmitC.h
index 0fc33bf790be4e..c61773026ca53d 100644
--- a/mlir/include/mlir/Conversion/MathToEmitC/MathToEmitC.h
+++ b/mlir/include/mlir/Conversion/MathToEmitC/MathToEmitC.h
@@ -8,7 +8,6 @@
#ifndef MLIR_CONVERSION_MATHTOEMITC_MATHTOEMITC_H
#define MLIR_CONVERSION_MATHTOEMITC_MATHTOEMITC_H
-#include "mlir/Dialect/EmitC/IR/EmitC.h"
namespace mlir {
class RewritePatternSet;
namespace emitc {
|
bondhugula
approved these changes
Feb 3, 2025
Icohedron
pushed a commit
to Icohedron/llvm-project
that referenced
this pull request
Feb 11, 2025
…ue (llvm#125466) This removes the unnecessary inclusion of mlir/Dialect/EmitC/IR/EmitC.h from MathToEmitC.h, which caused a build failure due to a missing EmitCEnums.h.inc. The include was not needed, and removing it resolves the issue without requiring additional dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the unnecessary inclusion of mlir/Dialect/EmitC/IR/EmitC.h from MathToEmitC.h, which caused a build failure due to a missing EmitCEnums.h.inc. The include was not needed, and removing it resolves the issue without requiring additional dependencies.