release/20.x: [llvm] Add CMake flag to compile out the telemetry framework (#124850) #125555
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@oontvoo What do you think about merging this PR to the release branch? |
oontvoo
approved these changes
Feb 3, 2025
cmtice
reviewed
Feb 3, 2025
Member
|
If I type |
Member
|
/cherrypick 13ded68 |
Member
That didn't work but the typo isn't critical for the release, so this is good to go. |
Contributor
|
@JDevlieghere See #125554 (comment) for how to add a comment. You have to run it in the place where you did the original cherry-pick and pass both commits at once. |
Member
|
Thanks @nikic! |
…4850) Add a CMake flag (LLVM_BUILD_TELEMETRY) to disable building the telemetry framework. The flag being enabled does *not* mean that telemetry is being collected, it merely means we're building the generic telemetry framework. Hence the flag is enabled by default. Motivated by this Discourse thread: https://discourse.llvm.org/t/how-to-disable-building-llvm-clang-telemetry/84305 (cherry picked from commit bac62ee)
Thanks Nikita for spotting it. (cherry picked from commit 13ded68)
|
@JDevlieghere (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport bac62ee
Requested by: @JDevlieghere