[libc] Set -fno-math-errno for FMA #125752
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to set -fno-math-errno so __builtin_fma* generate the fused-multiply-add instructions rather than an fma call.
Member
|
@llvm/pr-subscribers-libc Author: Petr Hosek (petrhosek) ChangesWe need to set -fno-math-errno so __builtin_fma* generate the fused-multiply-add instructions rather than an fma call. Full diff: https://github.com/llvm/llvm-project/pull/125752.diff 1 Files Affected:
diff --git a/libc/src/__support/FPUtil/CMakeLists.txt b/libc/src/__support/FPUtil/CMakeLists.txt
index 522b4afefd48d6..339bb58838564c 100644
--- a/libc/src/__support/FPUtil/CMakeLists.txt
+++ b/libc/src/__support/FPUtil/CMakeLists.txt
@@ -122,6 +122,10 @@ add_header_library(
libc.src.__support.FPUtil.generic.fma
FLAGS
FMA_OPT
+ COMPILE_OPTIONS
+ # We need to set -fno-math-errno so __builtin_fma* generate
+ # the fused-mutliply-add instructions rather than an fma call.
+ -fno-math-errno
)
add_header_library(
@@ -132,6 +136,10 @@ add_header_library(
libc.src.__support.common
FLAGS
FMA_OPT
+ COMPILE_OPTIONS
+ # We need to set -fno-math-errno so __builtin_fma* generate
+ # the fused-mutliply-add instructions rather than an fma call.
+ -fno-math-errno
)
add_header_library(
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to set -fno-math-errno so __builtin_fma* generate the fused-multiply-add instructions rather than an fma call.