[msan][NFCI] Add tests for sum long across vector #125761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently handled (suboptimally) by handleUnknownInstruction: - llvm.aarch64.neon.saddlv - llvm.aarch64.neon.uaddlv Forked from llvm/test/CodeGen/AArch64/arm64-vaddlv.ll
fmayer
reviewed
Feb 4, 2025
| target datalayout = "e-m:e-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128" | ||
| target triple = "aarch64--linux-android9001" | ||
|
|
||
| define i64 @test_vaddlv_s32(<2 x i32> %a1) nounwind readnone #0 { |
Contributor
There was a problem hiding this comment.
why is the test name different to the intrinsic name?
Contributor
Author
There was a problem hiding this comment.
This is cloned from llvm/test/CodeGen/AArch64/arm64-vaddlv.ll so I don't know for sure, but my guess is:
- they adopted a convention of "arm64-v" as the filename, to denote vector instructions
- internally, they use the filename for the test names (and append "_s" or "_u" for signed/unsigned)
vitalybuka
approved these changes
Feb 4, 2025
thurstond
added a commit
to thurstond/llvm-project
that referenced
this pull request
Feb 4, 2025
Apply handleVectorReduceIntrinsic() to llvm.aarch64.neon.[su]addlv. Previously, these were unknown intrinsics handled suboptimally by visitInstruction. Updates the tests from llvm#125761
thurstond
added a commit
to thurstond/llvm-project
that referenced
this pull request
Feb 6, 2025
Apply handleVectorReduceIntrinsic() to llvm.aarch64.neon.[su]addlv. Previously, these were unknown intrinsics handled suboptimally by visitInstruction. Updates the tests from llvm#125761
thurstond
added a commit
that referenced
this pull request
Feb 6, 2025
Apply handleVectorReduceIntrinsic() to llvm.aarch64.neon.[su]addlv. Previously, these were unknown intrinsics handled suboptimally by visitInstruction. Updates the tests from #125761
github-actions bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Feb 6, 2025
Apply handleVectorReduceIntrinsic() to llvm.aarch64.neon.[su]addlv. Previously, these were unknown intrinsics handled suboptimally by visitInstruction. Updates the tests from llvm/llvm-project#125761
Icohedron
pushed a commit
to Icohedron/llvm-project
that referenced
this pull request
Feb 11, 2025
Currently handled (suboptimally) by handleUnknownInstruction: - llvm.aarch64.neon.saddlv - llvm.aarch64.neon.uaddlv Forked from llvm/test/CodeGen/AArch64/arm64-vaddlv.ll
Icohedron
pushed a commit
to Icohedron/llvm-project
that referenced
this pull request
Feb 11, 2025
Apply handleVectorReduceIntrinsic() to llvm.aarch64.neon.[su]addlv. Previously, these were unknown intrinsics handled suboptimally by visitInstruction. Updates the tests from llvm#125761
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently handled (suboptimally) by handleUnknownInstruction:
Forked from llvm/test/CodeGen/AArch64/arm64-vaddlv.ll