Skip to content

Conversation

@tbaederr
Copy link
Contributor

@tbaederr tbaederr commented Feb 7, 2025

This doesn't seem to do any good and breaks a few libc++ tests. Remove the special case.

This doesn't seem to do any good and breaks a few libc++ tests. Remove
the special case.
@llvmbot llvmbot added clang Clang issues not falling into any other category clang:frontend Language frontend issues, e.g. anything involving "Sema" labels Feb 7, 2025
@llvmbot
Copy link
Member

llvmbot commented Feb 7, 2025

@llvm/pr-subscribers-clang

Author: Timm Baeder (tbaederr)

Changes

This doesn't seem to do any good and breaks a few libc++ tests. Remove the special case.


Full diff: https://github.com/llvm/llvm-project/pull/126223.diff

1 Files Affected:

  • (modified) clang/lib/AST/ByteCode/Compiler.cpp (-3)
diff --git a/clang/lib/AST/ByteCode/Compiler.cpp b/clang/lib/AST/ByteCode/Compiler.cpp
index 1e1e96a1c4782f4..1f0e022edcd7687 100644
--- a/clang/lib/AST/ByteCode/Compiler.cpp
+++ b/clang/lib/AST/ByteCode/Compiler.cpp
@@ -6234,9 +6234,6 @@ bool Compiler<Emitter>::visitDeclRef(const ValueDecl *D, const Expr *E) {
 
       return this->emitGetPtrParam(It->second.Offset, E);
     }
-
-    if (D->getType()->isReferenceType())
-      return this->emitDummyPtr(D, E);
   }
 
   // In case we need to re-visit a declaration.

@tbaederr tbaederr merged commit a69975d into llvm:main Feb 7, 2025
11 checks passed
Icohedron pushed a commit to Icohedron/llvm-project that referenced this pull request Feb 11, 2025
This doesn't seem to do any good and breaks a few libc++ tests. Remove
the special case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clang:frontend Language frontend issues, e.g. anything involving "Sema" clang Clang issues not falling into any other category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants