Skip to content

[compiler-rt][rtsan] adding readlink(a) interception #126262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2025
Merged

[compiler-rt][rtsan] adding readlink(a) interception #126262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions compiler-rt/lib/rtsan/rtsan_interceptors_posix.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,27 @@ INTERCEPTOR(int, fchdir, int fd) {
return REAL(fchdir)(fd);
}

#if SANITIZER_INTERCEPT_READLINK
INTERCEPTOR(ssize_t, readlink, const char *pathname, char *buf, size_t size) {
__rtsan_notify_intercepted_call("readlink");
return REAL(readlink)(pathname, buf, size);
}
#define RTSAN_MAYBE_INTERCEPT_READLINK INTERCEPT_FUNCTION(readlink)
#else
#define RTSAN_MAYBE_INTERCEPT_READLINK
#endif

#if SANITIZER_INTERCEPT_READLINKAT
INTERCEPTOR(ssize_t, readlinkat, int dirfd, const char *pathname, char *buf,
size_t size) {
__rtsan_notify_intercepted_call("readlinkat");
return REAL(readlinkat)(dirfd, pathname, buf, size);
}
#define RTSAN_MAYBE_INTERCEPT_READLINKAT INTERCEPT_FUNCTION(readlinkat)
#else
#define RTSAN_MAYBE_INTERCEPT_READLINKAT
#endif

// Streams

INTERCEPTOR(FILE *, fopen, const char *path, const char *mode) {
Expand Down Expand Up @@ -1402,6 +1423,8 @@ void __rtsan::InitializeInterceptors() {
INTERCEPT_FUNCTION(close);
INTERCEPT_FUNCTION(chdir);
INTERCEPT_FUNCTION(fchdir);
RTSAN_MAYBE_INTERCEPT_READLINK;
RTSAN_MAYBE_INTERCEPT_READLINKAT;
INTERCEPT_FUNCTION(fopen);
RTSAN_MAYBE_INTERCEPT_FOPEN64;
RTSAN_MAYBE_INTERCEPT_FREOPEN64;
Expand Down
18 changes: 18 additions & 0 deletions compiler-rt/lib/rtsan/tests/rtsan_test_interceptors_posix.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,6 +457,24 @@ TEST(TestRtsanInterceptors, FchdirDiesWhenRealtime) {
ExpectNonRealtimeSurvival(Func);
}

#if SANITIZER_INTERCEPT_READLINK
TEST(TestRtsanInterceptors, ReadlinkDiesWhenRealtime) {
char buf[1024];
auto Func = [&buf]() { readlink("/proc/self", buf, sizeof(buf)); };
ExpectRealtimeDeath(Func, "readlink");
ExpectNonRealtimeSurvival(Func);
}
#endif

#if SANITIZER_INTERCEPT_READLINKAT
TEST(TestRtsanInterceptors, ReadlinkatDiesWhenRealtime) {
char buf[1024];
auto Func = [&buf]() { readlinkat(0, "/proc/self", buf, sizeof(buf)); };
ExpectRealtimeDeath(Func, "readlinkat");
ExpectNonRealtimeSurvival(Func);
}
#endif

TEST_F(RtsanFileTest, FopenDiesWhenRealtime) {
auto Func = [this]() {
FILE *f = fopen(GetTemporaryFilePath(), "w");
Expand Down