[libc][stdfix] Fix buildbot failure because of a typo. #126291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-libc Author: Krishna Pandey (krishna2803) ChangesFix build-bot failure caused by #125356 Full diff: https://github.com/llvm/llvm-project/pull/126291.diff 1 Files Affected:
diff --git a/libc/src/__support/fixed_point/fx_bits.h b/libc/src/__support/fixed_point/fx_bits.h
index 21985e644253441..b9c065a3226d1c0 100644
--- a/libc/src/__support/fixed_point/fx_bits.h
+++ b/libc/src/__support/fixed_point/fx_bits.h
@@ -188,8 +188,8 @@ countls(T f) {
constexpr int PADDING_LEN = CONTAIN_LEN - FXRep::TOTAL_LEN;
if constexpr (FXRep::SIGN_LEN != 0) {
- if (x < 0)
- x = bit_not(x);
+ if (f < 0)
+ f = bit_not(f);
}
BitType value_bits = FXBits(x)::get_bits();
|
| f = bit_not(f); | ||
| } | ||
|
|
||
| BitType value_bits = FXBits(x)::get_bits(); |
Contributor
Author
There was a problem hiding this comment.
ah.. sorry about that! fixed in caa32e6e
| x = bit_not(x); | ||
| if (f < 0) | ||
| f = bit_not(f); | ||
| } |
Member
There was a problem hiding this comment.
Also, please remove {} from if constexpr.
https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements
jhuber6
approved these changes
Feb 7, 2025
| f = bit_not(f); | ||
|
|
||
| BitType value_bits = FXBits(x)::get_bits(); | ||
| BitType value_bits = FXBits(f)::get_bits(); |
Member
There was a problem hiding this comment.
Still failing on the buildbots:
libc/src/__support/fixed_point/fx_bits.h:194:11: error: no viable conversion from 'FXBits' (aka 'FXBits<unsigned long _Fract>') to 'BitType' (aka 'unsigned int')
194 | BitType value_bits = FXBits(f)::get_bits();
| ^ ~~~~~~~~~
/home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian/libc-x86_64-debian-dbg-bootstrap-build/llvm-project/libc/src/stdfix/countlsulr.cpp:17:23: note: in instantiation of function template specialization '__llvm_libc_20_0_0_git::fixed_point::countls<unsigned long _Fract>' requested here
17 | return fixed_point::countls(f);
| ^
Member
There was a problem hiding this comment.
Was :: supposed to be .?
jhuber6
added a commit
that referenced
this pull request
Feb 7, 2025
Icohedron
pushed a commit
to Icohedron/llvm-project
that referenced
this pull request
Feb 11, 2025
Fix build-bot failure caused by llvm#125356
Icohedron
pushed a commit
to Icohedron/llvm-project
that referenced
this pull request
Feb 11, 2025
…126291)" This reverts commit bada922. Revert "[libc][stdfix] Implement fixed point `countlsfx` functions in llvm-libc (llvm#125356)" This reverts commit f2a1103.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix build-bot failure caused by #125356