Skip to content

[libc][stdfix] Fix buildbot failure because of a typo. #126291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 7, 2025
Merged

[libc][stdfix] Fix buildbot failure because of a typo. #126291

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11fe65a
fix: buildbot failure
krishna2803 Feb 7, 2025
caa32e6
fix: change to single line if for countls and change x to f (typo)
krishna2803 Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libc/src/__support/fixed_point/fx_bits.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,8 +188,8 @@ countls(T f) {
constexpr int PADDING_LEN = CONTAIN_LEN - FXRep::TOTAL_LEN;

if constexpr (FXRep::SIGN_LEN != 0) {
if (x < 0)
x = bit_not(x);
if (f < 0)
f = bit_not(f);
}
Copy link
Member

@nickdesaulniers nickdesaulniers Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please remove {} from if constexpr.
https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements

Copy link
Contributor Author

@krishna2803 krishna2803 Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved in caa32e6e


BitType value_bits = FXBits(x)::get_bits();
Copy link
Member

@nickdesaulniers nickdesaulniers Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about x here?

Copy link
Contributor Author

@krishna2803 krishna2803 Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah.. sorry about that! fixed in caa32e6e

Expand Down