Skip to content

[libc][pthread] fix -Wmissing-field-initializers #126314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 12, 2025
Merged

[libc][pthread] fix -Wmissing-field-initializers #126314

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6ef84f2
[libc][pthread] fix -Wmissing-field-initializers
nickdesaulniers Feb 7, 2025
c380f97
switch to aggregate initialization
nickdesaulniers Feb 10, 2025
bfc84ca
s/gnu::unused/maybe_unused/
nickdesaulniers Feb 10, 2025
868122b
reformat
nickdesaulniers Feb 10, 2025
0f16df9
fix include path
nickdesaulniers Feb 10, 2025
ff3e6d9
cmake
nickdesaulniers Feb 11, 2025
2da1ce2
attempt reformat
nickdesaulniers Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libc/include/llvm-libc-macros/pthread-macros.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
#define PTHREAD_PROCESS_PRIVATE 0
#define PTHREAD_PROCESS_SHARED 1

#define PTHREAD_MUTEX_INITIALIZER {0}
#define PTHREAD_RWLOCK_INITIALIZER {0}
#define PTHREAD_MUTEX_INITIALIZER {}
#define PTHREAD_RWLOCK_INITIALIZER {}

// glibc extensions
#define PTHREAD_STACK_MIN (1 << 14) // 16KB
Expand Down
4 changes: 4 additions & 0 deletions libc/test/integration/src/pthread/pthread_mutex_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,10 @@ void multiple_waiters() {
LIBC_NAMESPACE::pthread_mutex_destroy(&counter_lock);
}

// Test the initializer
[[gnu::unused]]
Copy link
Contributor

@lntue lntue Feb 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not [[maybe_unused]]?

Copy link
Member Author

@nickdesaulniers nickdesaulniers Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! I always forget that that one got standardized.
bfc84ca

static pthread_mutex_t test_initializer = PTHREAD_MUTEX_INITIALIZER;

TEST_MAIN() {
relay_counter();
wait_and_step();
Expand Down
Loading