[RISCV] Include RISCVGenSearchTable.inc in RISCVISelDAGToDAG.h #126326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-backend-risc-v Author: Min-Yih Hsu (mshockwave) ChangesThis line was previously removed when 12d4724 moved it to RISCVInstrInfo.h. But we probably don't want to have dangling Full diff: https://github.com/llvm/llvm-project/pull/126326.diff 1 Files Affected:
diff --git a/llvm/lib/Target/RISCV/RISCVISelDAGToDAG.h b/llvm/lib/Target/RISCV/RISCVISelDAGToDAG.h
index 592f517358506b..bb786e4b2bb40f 100644
--- a/llvm/lib/Target/RISCV/RISCVISelDAGToDAG.h
+++ b/llvm/lib/Target/RISCV/RISCVISelDAGToDAG.h
@@ -278,6 +278,7 @@ struct VLX_VSXPseudo {
#define GET_RISCVVSETable_DECL
#define GET_RISCVVLXTable_DECL
#define GET_RISCVVSXTable_DECL
+#include "RISCVGenSearchableTables.inc"
} // namespace RISCV
} // namespace llvm
|
Icohedron
pushed a commit
to Icohedron/llvm-project
that referenced
this pull request
Feb 11, 2025
…126326) This line was previously removed when 12d4724 moved it to RISCVInstrInfo.h. But we probably don't want to have dangling `#define *_DECL` (RISCVGenSearchableTables.inc will `#undef` these macros) and I think there is no harm putting declarations of those search table functions in RISCVISelDAGToDAG.h.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This line was previously removed when 12d4724 moved it to RISCVInstrInfo.h. But we probably don't want to have dangling
#define *_DECL(RISCVGenSearchableTables.inc will#undefthese macros) and I think there is no harm putting declarations of those search table functions in RISCVISelDAGToDAG.h.