[AMDGPU] Avoid repeated hash lookups (NFC) #126401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch just cleans up the "if" condition. Further cleanups are left to subsequent patches.
Member
|
@llvm/pr-subscribers-backend-amdgpu Author: Kazu Hirata (kazutakahirata) ChangesThis patch just cleans up the "if" condition. Further cleanups are Full diff: https://github.com/llvm/llvm-project/pull/126401.diff 1 Files Affected:
diff --git a/llvm/lib/Target/AMDGPU/AMDGPULateCodeGenPrepare.cpp b/llvm/lib/Target/AMDGPU/AMDGPULateCodeGenPrepare.cpp
index f4e651ec477d30a..b8109db821bcc38 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPULateCodeGenPrepare.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPULateCodeGenPrepare.cpp
@@ -367,11 +367,11 @@ bool LiveRegOptimizer::optimizeLiveType(
for (Instruction *U : Uses) {
// Replace all converted operands for a use.
for (auto [OpIdx, Op] : enumerate(U->operands())) {
- if (ValMap.contains(Op) && ValMap[Op]) {
+ if (Value *Val = ValMap.lookup(Op)) {
Value *NewVal = nullptr;
if (BBUseValMap.contains(U->getParent()) &&
- BBUseValMap[U->getParent()].contains(ValMap[Op]))
- NewVal = BBUseValMap[U->getParent()][ValMap[Op]];
+ BBUseValMap[U->getParent()].contains(Val))
+ NewVal = BBUseValMap[U->getParent()][Val];
else {
BasicBlock::iterator InsertPt = U->getParent()->getFirstNonPHIIt();
// We may pick up ops that were previously converted for users in
|
arsenm
approved these changes
Feb 9, 2025
kazutakahirata
deleted the
cleanup_001_repeated_hash_lookups_llvm_AMDGPU
branch
Icohedron
pushed a commit
to Icohedron/llvm-project
that referenced
this pull request
Feb 11, 2025
This patch just cleans up the "if" condition. Further cleanups are left to subsequent patches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch just cleans up the "if" condition. Further cleanups are
left to subsequent patches.