[Object] Avoid repeated map lookups (NFC) #126853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-llvm-binary-utilities Author: Kazu Hirata (kazutakahirata) ChangesFull diff: https://github.com/llvm/llvm-project/pull/126853.diff 1 Files Affected:
diff --git a/llvm/lib/Object/GOFFObjectFile.cpp b/llvm/lib/Object/GOFFObjectFile.cpp
index db1e7e704f62e..7806953aecd29 100644
--- a/llvm/lib/Object/GOFFObjectFile.cpp
+++ b/llvm/lib/Object/GOFFObjectFile.cpp
@@ -564,8 +564,7 @@ section_iterator GOFFObjectFile::section_end() const {
void GOFFObjectFile::moveSymbolNext(DataRefImpl &Symb) const {
for (uint32_t I = Symb.d.a + 1, E = EsdPtrs.size(); I < E; ++I) {
- if (EsdPtrs[I]) {
- const uint8_t *EsdRecord = EsdPtrs[I];
+ if (const uint8_t *EsdRecord = EsdPtrs[I]) {
GOFF::ESDSymbolType SymbolType;
ESDRecord::getSymbolType(EsdRecord, SymbolType);
// Skip EDs - i.e. section symbols.
|
kazutakahirata
deleted the
cleanup_001_repeated_hash_lookups_llvm_Object
branch
flovent
pushed a commit
to flovent/llvm-project
that referenced
this pull request
Feb 13, 2025
joaosaffran
pushed a commit
to joaosaffran/llvm-project
that referenced
this pull request
Feb 14, 2025
sivan-shani
pushed a commit
to sivan-shani/llvm-project
that referenced
this pull request
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.