Skip to content

[hwasan][NFCI] Rename ClRandomSkipRate to ClRandomKeepRate #126990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 13, 2025
Merged

[hwasan][NFCI] Rename ClRandomSkipRate to ClRandomKeepRate #126990

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c31d325
[hwasan][NFCI] Rename ClRandomSkipRate to ClRandomKeepRate
thurstond Feb 13, 2025
d2b8e3f
Improve wording per Florian
thurstond Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,9 +195,11 @@ static cl::opt<int> ClHotPercentileCutoff("hwasan-percentile-cutoff-hot",
cl::desc("Hot percentile cutoff."));

static cl::opt<float>
ClRandomSkipRate("hwasan-random-rate",
ClRandomKeepRate("hwasan-random-rate",
cl::desc("Probability value in the range [0.0, 1.0] "
"to keep instrumentation of a function."));
"to keep instrumentation of a function. "
"Note: instrumentation can be skipped randomly "
"OR because of the hot percentile cutoff."));

STATISTIC(NumTotalFuncs, "Number of total funcs");
STATISTIC(NumInstrumentedFuncs, "Number of instrumented funcs");
Expand Down Expand Up @@ -301,7 +303,7 @@ class HWAddressSanitizer {
: M(M), SSI(SSI) {
this->Recover = optOr(ClRecover, Recover);
this->CompileKernel = optOr(ClEnableKhwasan, CompileKernel);
this->Rng = ClRandomSkipRate.getNumOccurrences() ? M.createRNG(DEBUG_TYPE)
this->Rng = ClRandomKeepRate.getNumOccurrences() ? M.createRNG(DEBUG_TYPE)
: nullptr;

initializeModule();
Expand Down Expand Up @@ -1599,9 +1601,9 @@ bool HWAddressSanitizer::selectiveInstrumentationShouldSkip(
};

auto SkipRandom = [&]() {
if (!ClRandomSkipRate.getNumOccurrences())
if (!ClRandomKeepRate.getNumOccurrences())
return false;
std::bernoulli_distribution D(ClRandomSkipRate);
std::bernoulli_distribution D(ClRandomKeepRate);
return !D(*Rng);
};

Expand Down