workflows/release-binaries: Disable Flang on x86_64 macOS #127216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flang build was taking 2-3 hours and causing the entire job to timeout, so we need to disable it.
Member
|
@llvm/pr-subscribers-github-workflow Author: Tom Stellard (tstellar) ChangesThe flang build was taking 2-3 hours and causing the entire job to timeout, so we need to disable it. Full diff: https://github.com/llvm/llvm-project/pull/127216.diff 1 Files Affected:
diff --git a/.github/workflows/release-binaries.yml b/.github/workflows/release-binaries.yml
index 398734c1a366d..64d59a5a6449d 100644
--- a/.github/workflows/release-binaries.yml
+++ b/.github/workflows/release-binaries.yml
@@ -138,6 +138,11 @@ jobs:
arches=arm64
else
arches=x86_64
+ # Disable Flang builds on macOS x86_64. The FortranLower library takes
+ # 2-3 hours to build on macOS, much slower than on Linux.
+ # The long build time causes the release build to time out on x86_64,
+ # so we need to disable flang there.
+ target_cmake_flags="$target_cmake_flags -DLLVM_RELEASE_ENABLE_PROJECTS='clang;lld;lldb;clang-tools-extra;bolt;polly;mlir'"
fi
target_cmake_flags="$target_cmake_flags -DBOOTSTRAP_BOOTSTRAP_DARWIN_osx_ARCHS=$arches -DBOOTSTRAP_BOOTSTRAP_DARWIN_osx_BUILTIN_ARCHS=$arches"
fi
|
boomanaiden154
approved these changes
Feb 14, 2025
Contributor
boomanaiden154
left a comment
boomanaiden154
left a comment
There was a problem hiding this comment.
LGTM.
I'm wondering if compiling just uses too much RAM and it goes to swap?
Collaborator
Author
It could be, the large X86_64 mac runners have a low RAM/CPU ratio: 30/12. The Linux runners are 64/16 and it builds fine there. Maybe I need to try to get this working again: #95672 |
Collaborator
Author
|
/cherry-pick 3e5ae57 |
Member
|
/pull-request #127951 |
swift-ci
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Feb 20, 2025
The flang build was taking 2-3 hours and causing the entire job to timeout, so we need to disable it. (cherry picked from commit 3e5ae57)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flang build was taking 2-3 hours and causing the entire job to timeout, so we need to disable it.