diff --git a/llvm/include/llvm/CGData/CodeGenData.h b/llvm/include/llvm/CGData/CodeGenData.h index da0e412f2a0e0..0e7dd2f5b5c1a 100644 --- a/llvm/include/llvm/CGData/CodeGenData.h +++ b/llvm/include/llvm/CGData/CodeGenData.h @@ -265,7 +265,7 @@ std::unique_ptr loadModuleForTwoRounds(BitcodeModule &OrigModule, Expected mergeCodeGenData(ArrayRef ObjectFiles); void warn(Error E, StringRef Whence = ""); -void warn(Twine Message, std::string Whence = "", std::string Hint = ""); +void warn(Twine Message, StringRef Whence = "", StringRef Hint = ""); } // end namespace cgdata diff --git a/llvm/lib/CGData/CodeGenData.cpp b/llvm/lib/CGData/CodeGenData.cpp index 88dcdfd1f931a..bb6b9c7721d55 100644 --- a/llvm/lib/CGData/CodeGenData.cpp +++ b/llvm/lib/CGData/CodeGenData.cpp @@ -204,7 +204,7 @@ Expected
Header::readFromBuffer(const unsigned char *Curr) { namespace cgdata { -void warn(Twine Message, std::string Whence, std::string Hint) { +void warn(Twine Message, StringRef Whence, StringRef Hint) { WithColor::warning(); if (!Whence.empty()) errs() << Whence << ": "; @@ -216,7 +216,7 @@ void warn(Twine Message, std::string Whence, std::string Hint) { void warn(Error E, StringRef Whence) { if (E.isA()) { handleAllErrors(std::move(E), [&](const CGDataError &IPE) { - warn(IPE.message(), Whence.str(), ""); + warn(IPE.message(), Whence, ""); }); } }