-
Notifications
You must be signed in to change notification settings - Fork 15.3k
[VectorCombine] Handle shuffle of selects #128032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
2a4dfdf
4c989b9
4a551ed
17a6939
f784d41
bf1d91d
4e9e6a8
42b4bf4
575a897
d85f8df
82aeff7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -119,6 +119,7 @@ class VectorCombine { | |
| bool foldConcatOfBoolMasks(Instruction &I); | ||
| bool foldPermuteOfBinops(Instruction &I); | ||
| bool foldShuffleOfBinops(Instruction &I); | ||
| bool foldShuffleOfSelects(Instruction &I); | ||
| bool foldShuffleOfCastops(Instruction &I); | ||
| bool foldShuffleOfShuffles(Instruction &I); | ||
| bool foldShuffleOfIntrinsics(Instruction &I); | ||
|
|
@@ -1899,6 +1900,65 @@ bool VectorCombine::foldShuffleOfBinops(Instruction &I) { | |
| return true; | ||
| } | ||
|
|
||
| /// Try to convert, | ||
| /// (shuffle(select(c1,t1,f1)), (select(c2,t2,f2)), m) into | ||
| /// (select (shuffle c1,c2,m), (shuffle t1,t2,m), (shuffle f1,f2,m)) | ||
| bool VectorCombine::foldShuffleOfSelects(Instruction &I) { | ||
| ArrayRef<int> Mask; | ||
| Value *C1, *T1, *F1, *C2, *T2, *F2; | ||
| if (!match(&I, m_Shuffle( | ||
| m_OneUse(m_Select(m_Value(C1), m_Value(T1), m_Value(F1))), | ||
| m_OneUse(m_Select(m_Value(C2), m_Value(T2), m_Value(F2))), | ||
| m_Mask(Mask)))) | ||
| return false; | ||
|
|
||
| auto *DstVecTy = dyn_cast<FixedVectorType>(I.getType()); | ||
| auto *C1VecTy = dyn_cast<FixedVectorType>(C1->getType()); | ||
| auto *C2VecTy = dyn_cast<FixedVectorType>(C2->getType()); | ||
| if (!C1VecTy || !C2VecTy) | ||
| return false; | ||
|
|
||
| auto *Select0 = cast<Instruction>(I.getOperand(0)); | ||
| if (auto *SI0FOp = dyn_cast<FPMathOperator>(Select0)) | ||
| if (auto *SI1FOp = dyn_cast<FPMathOperator>((I.getOperand(1)))) | ||
| if (SI0FOp->getFastMathFlags() != SI1FOp->getFastMathFlags()) | ||
|
||
| return false; | ||
|
|
||
| auto SK = TargetTransformInfo::SK_PermuteTwoSrc; | ||
| auto SelOp = Instruction::Select; | ||
| InstructionCost OldCost = TTI.getCmpSelInstrCost( | ||
| SelOp, T1->getType(), C1VecTy, CmpInst::BAD_ICMP_PREDICATE, CostKind); | ||
| OldCost += TTI.getCmpSelInstrCost(SelOp, T2->getType(), C2VecTy, | ||
| CmpInst::BAD_ICMP_PREDICATE, CostKind); | ||
| OldCost += TTI.getShuffleCost(SK, DstVecTy, Mask, CostKind, 0, nullptr, | ||
| {I.getOperand(0), I.getOperand(1)}, &I); | ||
|
|
||
| auto *C1C2VecTy = cast<FixedVectorType>( | ||
| toVectorTy(Type::getInt1Ty(I.getContext()), DstVecTy->getNumElements())); | ||
| InstructionCost NewCost = | ||
| TTI.getShuffleCost(SK, C1C2VecTy, Mask, CostKind, 0, nullptr, {C1, C2}); | ||
| NewCost += | ||
| TTI.getShuffleCost(SK, DstVecTy, Mask, CostKind, 0, nullptr, {T1, T2}); | ||
| NewCost += | ||
| TTI.getShuffleCost(SK, DstVecTy, Mask, CostKind, 0, nullptr, {F1, F2}); | ||
| NewCost += TTI.getCmpSelInstrCost(SelOp, DstVecTy, DstVecTy, | ||
| CmpInst::BAD_ICMP_PREDICATE, CostKind); | ||
|
|
||
| if (NewCost > OldCost) | ||
RKSimon marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| return false; | ||
|
|
||
| Value *ShuffleCmp = Builder.CreateShuffleVector(C1, C2, Mask); | ||
| Value *ShuffleTrue = Builder.CreateShuffleVector(T1, T2, Mask); | ||
| Value *ShuffleFalse = Builder.CreateShuffleVector(F1, F2, Mask); | ||
| Value *NewSel = Builder.CreateSelect(ShuffleCmp, ShuffleTrue, ShuffleFalse); | ||
| if (isa<FPMathOperator>(NewSel)) | ||
|
||
| cast<Instruction>(NewSel)->setFastMathFlags(Select0->getFastMathFlags()); | ||
RKSimon marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| Worklist.pushValue(NewSel); | ||
|
||
| replaceValue(I, *NewSel); | ||
| return true; | ||
| } | ||
|
|
||
| /// Try to convert "shuffle (castop), (castop)" with a shared castop operand | ||
| /// into "castop (shuffle)". | ||
| bool VectorCombine::foldShuffleOfCastops(Instruction &I) { | ||
|
|
@@ -3352,6 +3412,7 @@ bool VectorCombine::run() { | |
| case Instruction::ShuffleVector: | ||
| MadeChange |= foldPermuteOfBinops(I); | ||
| MadeChange |= foldShuffleOfBinops(I); | ||
| MadeChange |= foldShuffleOfSelects(I); | ||
| MadeChange |= foldShuffleOfCastops(I); | ||
| MadeChange |= foldShuffleOfShuffles(I); | ||
| MadeChange |= foldShuffleOfIntrinsics(I); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can C1VecTy != C2VecTy?