Skip to content

[utils] Use stricter SSA regexp for CHECK-SAME. #128083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 21, 2025
Merged

[utils] Use stricter SSA regexp for CHECK-SAME. #128083

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e3c767c
[utils] Use stricter SSA regexp for CHECK-SAME.
vzakhari Feb 20, 2025
37a80d4
Changed var name.
vzakhari Feb 21, 2025
fbbea57
format
vzakhari Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions mlir/utils/generate-test-checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ def get_num_ssa_results(input_line):


# Process a line of input that has been split at each SSA identifier '%'.
def process_line(line_chunks, variable_namer):
def process_line(line_chunks, variable_namer, strict=False):
output_line = ""

# Process the rest that contained an SSA value name.
Expand All @@ -180,7 +180,14 @@ def process_line(line_chunks, variable_namer):
else:
# Otherwise, generate a new variable.
variable = variable_namer.generate_name(ssa_name)
output_line += "%[[" + variable + ":.*]]"
if strict:
Copy link
Contributor

@River707 River707 Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use a more descriptive name here? Something like strict_name_re, just to be a bit more clear.

# Use stricter regexp for the variable name, if requested.
# Greedy matching may cause issues with the generic '.*'
# regexp when the checks are split across several
# lines (e.g. for CHECK-SAME).
output_line += "%[[" + variable + ":" + SSA_RE_STR + "]]"
else:
output_line += "%[[" + variable + ":.*]]"

# Append the non named group.
output_line += chunk[len(ssa_name) :]
Expand Down Expand Up @@ -390,7 +397,7 @@ def main():
output_line += " " * len(ssa_split[0])

# Process the rest of the line.
output_line += process_line([argument], variable_namer)
output_line += process_line([argument], variable_namer, strict=True)

# Append the output line.
output_segments[-1].append(output_line)
Expand Down
Loading