Skip to content

[DebugInfo] Avoid repeated hash lookups (NFC) #128127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2025
Merged

[DebugInfo] Avoid repeated hash lookups (NFC) #128127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 8 additions & 14 deletions llvm/lib/DebugInfo/LogicalView/Readers/LVCodeViewVisitor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,29 +155,23 @@ class LVForwardReferences {
}

void add(StringRef Name, TypeIndex TIForward) {
if (ForwardTypesNames.find(Name) == ForwardTypesNames.end()) {
ForwardTypesNames.emplace(
std::piecewise_construct, std::forward_as_tuple(Name),
std::forward_as_tuple(TIForward, TypeIndex::None()));
} else {
auto [It, Inserted] =
ForwardTypesNames.try_emplace(Name, TIForward, TypeIndex::None());
if (!Inserted) {
// Update a recorded definition with its reference.
ForwardTypesNames[Name].first = TIForward;
add(TIForward, ForwardTypesNames[Name].second);
It->second.first = TIForward;
add(TIForward, It->second.second);
}
}

// Update a previously recorded forward reference with its definition.
void update(StringRef Name, TypeIndex TIReference) {
auto It = ForwardTypesNames.find(Name);
if (It != ForwardTypesNames.end()) {
auto [It, Inserted] =
ForwardTypesNames.try_emplace(Name, TypeIndex::None(), TIReference);
if (!Inserted) {
// Update the recorded forward reference with its definition.
It->second.second = TIReference;
add(It->second.first, TIReference);
} else {
// We have not seen the forward reference. Insert the definition.
ForwardTypesNames.emplace(
std::piecewise_construct, std::forward_as_tuple(Name),
std::forward_as_tuple(TypeIndex::None(), TIReference));
}
}

Expand Down
Loading