Skip to content

Conversation

@aganea
Copy link
Member

@aganea aganea commented Feb 22, 2025

Since the 19.0 release, they aren't required anymore, as we link the CRT statically into all distributed binaries.

https://discourse.llvm.org/t/llvm-x86-64-pc-windows-msvc-binaries-no-longer-need-msvc-runtime-dlls-since-19-x/84465

Since the 19.0 they aren't required anymore, since we link the CRT statically into all distributed binaries.
@aganea aganea requested a review from zmodem February 22, 2025 23:23
Copy link
Collaborator

@zmodem zmodem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dug through the code to find out why we were shipping the UCRT to begin with. The reason seems to have been #31047 and cfd0b6f

Since nobody complained since, I guess that might not be a problem anymore?

Anyway, it doesn't make sense to include the UCRT when we're linking statically.

@aganea aganea merged commit 4ba3ebe into llvm:main Feb 24, 2025
12 checks passed
@aganea
Copy link
Member Author

aganea commented Feb 25, 2025

/cherry-pick 4ba3ebe

@aganea aganea added this to the LLVM 20.X Release milestone Feb 25, 2025
@llvmbot
Copy link
Member

llvmbot commented Feb 25, 2025

/pull-request #128720

swift-ci pushed a commit to swiftlang/llvm-project that referenced this pull request Feb 25, 2025
…28378)

Since the 19.0 release, the UCRT dlls shouldn't be included anymore in the Windows distribution, as we link the CRT
statically into all distributed binaries.

https://discourse.llvm.org/t/llvm-x86-64-pc-windows-msvc-binaries-no-longer-need-msvc-runtime-dlls-since-19-x/84465
(cherry picked from commit 4ba3ebe)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants