[flang] Extend omp loop semantic checks for reduction
#128823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
flang
Member
|
@llvm/pr-subscribers-flang-openmp Author: Kareem Ergawy (ergawy) ChangesExtend semantic checks for This is similar to how clang behaves. Full diff: https://github.com/llvm/llvm-project/pull/128823.diff 2 Files Affected:
diff --git a/flang/lib/Semantics/check-omp-structure.cpp b/flang/lib/Semantics/check-omp-structure.cpp
index ef7204dcd9196..e6e36b773b3c5 100644
--- a/flang/lib/Semantics/check-omp-structure.cpp
+++ b/flang/lib/Semantics/check-omp-structure.cpp
@@ -3118,6 +3118,18 @@ void OmpStructureChecker::Enter(const parser::OmpClause::Reduction &x) {
if (llvm::omp::nestedReduceWorkshareAllowedSet.test(GetContext().directive)) {
CheckSharedBindingInOuterContext(objects);
}
+
+ if (GetContext().directive == llvm::omp::Directive::OMPD_loop) {
+ for (auto clause : GetContext().clauseInfo) {
+ if (const auto *bindClause{
+ std::get_if<parser::OmpClause::Bind>(&clause.second->u)}) {
+ if (bindClause->v.v == parser::OmpBindClause::Binding::Teams) {
+ context_.Say(GetContext().clauseSource,
+ "'REDUCTION' clause not allowed with '!$OMP LOOP BIND(TEAMS)."_err_en_US);
+ }
+ }
+ }
+ }
}
void OmpStructureChecker::Enter(const parser::OmpClause::InReduction &x) {
diff --git a/flang/test/Semantics/OpenMP/loop-bind.f90 b/flang/test/Semantics/OpenMP/loop-bind.f90
index f3aa9d19fe989..8f03910644370 100644
--- a/flang/test/Semantics/OpenMP/loop-bind.f90
+++ b/flang/test/Semantics/OpenMP/loop-bind.f90
@@ -30,4 +30,9 @@ program main
end do
!$omp end teams loop
+ !ERROR: 'REDUCTION' clause not allowed with '!$OMP LOOP BIND(TEAMS).
+ !$omp loop bind(teams) reduction(+: x)
+ do i = 0, 10
+ x = x + i
+ end do
end program main
|
Member
|
@llvm/pr-subscribers-flang-semantics Author: Kareem Ergawy (ergawy) ChangesExtend semantic checks for This is similar to how clang behaves. Full diff: https://github.com/llvm/llvm-project/pull/128823.diff 2 Files Affected:
diff --git a/flang/lib/Semantics/check-omp-structure.cpp b/flang/lib/Semantics/check-omp-structure.cpp
index ef7204dcd9196..e6e36b773b3c5 100644
--- a/flang/lib/Semantics/check-omp-structure.cpp
+++ b/flang/lib/Semantics/check-omp-structure.cpp
@@ -3118,6 +3118,18 @@ void OmpStructureChecker::Enter(const parser::OmpClause::Reduction &x) {
if (llvm::omp::nestedReduceWorkshareAllowedSet.test(GetContext().directive)) {
CheckSharedBindingInOuterContext(objects);
}
+
+ if (GetContext().directive == llvm::omp::Directive::OMPD_loop) {
+ for (auto clause : GetContext().clauseInfo) {
+ if (const auto *bindClause{
+ std::get_if<parser::OmpClause::Bind>(&clause.second->u)}) {
+ if (bindClause->v.v == parser::OmpBindClause::Binding::Teams) {
+ context_.Say(GetContext().clauseSource,
+ "'REDUCTION' clause not allowed with '!$OMP LOOP BIND(TEAMS)."_err_en_US);
+ }
+ }
+ }
+ }
}
void OmpStructureChecker::Enter(const parser::OmpClause::InReduction &x) {
diff --git a/flang/test/Semantics/OpenMP/loop-bind.f90 b/flang/test/Semantics/OpenMP/loop-bind.f90
index f3aa9d19fe989..8f03910644370 100644
--- a/flang/test/Semantics/OpenMP/loop-bind.f90
+++ b/flang/test/Semantics/OpenMP/loop-bind.f90
@@ -30,4 +30,9 @@ program main
end do
!$omp end teams loop
+ !ERROR: 'REDUCTION' clause not allowed with '!$OMP LOOP BIND(TEAMS).
+ !$omp loop bind(teams) reduction(+: x)
+ do i = 0, 10
+ x = x + i
+ end do
end program main
|
Member
Author
|
Ping! Please take a look when you have time. |
mjklemm
approved these changes
Feb 27, 2025
Contributor
mjklemm
left a comment
mjklemm
left a comment
There was a problem hiding this comment.
LGTM, except the two nits about missing an ' sign in the error message.
Extend semantic checks for `omp loop` directive to report errors when a `reduction` clause is specified on a standalone `loop` directive with `teams` binding. This is similar to how clang behaves.
ergawy
force-pushed
the
users/ergawy/loop_reduction_1
branch
from
8f2c57e to
5b88e7d
Compare
joaosaffran
pushed a commit
to joaosaffran/llvm-project
that referenced
this pull request
Mar 3, 2025
Extend semantic checks for `omp loop` directive to report errors when a `reduction` clause is specified on a standalone `loop` directive with `teams` binding. This is similar to how clang behaves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend semantic checks for
omp loopdirective to report errors when areductionclause is specified on a standaloneloopdirective withteamsbinding.This is similar to how clang behaves.