Skip to content

[compiler-rt][rtsan] truncate/ftruncate interception. #128904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025
Merged

[compiler-rt][rtsan] truncate/ftruncate interception. #128904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions compiler-rt/lib/rtsan/rtsan_interceptors_posix.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,33 @@ INTERCEPTOR(int, unlinkat, int fd, const char *pathname, int flag) {
return REAL(unlinkat)(fd, pathname, flag);
}

INTERCEPTOR(int, truncate, const char *pathname, off_t length) {
__rtsan_notify_intercepted_call("truncate");
return REAL(truncate)(pathname, length);
}

INTERCEPTOR(int, ftruncate, int fd, off_t length) {
__rtsan_notify_intercepted_call("ftruncate");
return REAL(ftruncate)(fd, length);
}

#if SANITIZER_LINUX
INTERCEPTOR(int, truncate64, const char *pathname, off64_t length) {
__rtsan_notify_intercepted_call("truncate64");
return REAL(truncate64)(pathname, length);
}

INTERCEPTOR(int, ftruncate64, int fd, off64_t length) {
__rtsan_notify_intercepted_call("ftruncate64");
return REAL(ftruncate64)(fd, length);
}
#define RTSAN_MAYBE_INTERCEPT_TRUNCATE64 INTERCEPT_FUNCTION(truncate64)
#define RTSAN_MAYBE_INTERCEPT_FTRUNCATE64 INTERCEPT_FUNCTION(ftruncate64)
#else
#define RTSAN_MAYBE_INTERCEPT_TRUNCATE64
#define RTSAN_MAYBE_INTERCEPT_FTRUNCATE64
#endif

// Streams

INTERCEPTOR(FILE *, fopen, const char *path, const char *mode) {
Expand Down Expand Up @@ -1437,6 +1464,10 @@ void __rtsan::InitializeInterceptors() {
RTSAN_MAYBE_INTERCEPT_READLINKAT;
INTERCEPT_FUNCTION(unlink);
INTERCEPT_FUNCTION(unlinkat);
INTERCEPT_FUNCTION(truncate);
INTERCEPT_FUNCTION(ftruncate);
RTSAN_MAYBE_INTERCEPT_TRUNCATE64;
RTSAN_MAYBE_INTERCEPT_FTRUNCATE64;
INTERCEPT_FUNCTION(fopen);
RTSAN_MAYBE_INTERCEPT_FOPEN64;
RTSAN_MAYBE_INTERCEPT_FREOPEN64;
Expand Down
16 changes: 14 additions & 2 deletions compiler-rt/lib/rtsan/tests/rtsan_test_interceptors_posix.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ TEST_F(RtsanFileTest, FcntlFlockDiesWhenRealtime) {
ASSERT_THAT(fd, Ne(-1));

auto Func = [fd]() {
struct flock lock {};
struct flock lock{};
lock.l_type = F_RDLCK;
lock.l_whence = SEEK_SET;
lock.l_start = 0;
Expand Down Expand Up @@ -735,7 +735,7 @@ TEST(TestRtsanInterceptors, IoctlBehavesWithOutputPointer) {
GTEST_SKIP();
}

struct ifreq ifr {};
struct ifreq ifr{};
strncpy(ifr.ifr_name, ifaddr->ifa_name, IFNAMSIZ - 1);

int retval = ioctl(sock, SIOCGIFADDR, &ifr);
Expand Down Expand Up @@ -875,6 +875,18 @@ TEST_F(RtsanOpenedFileTest, UnlinkatDiesWhenRealtime) {
ExpectNonRealtimeSurvival(Func);
}

TEST_F(RtsanOpenedFileTest, TruncateDiesWhenRealtime) {
auto Func = [&]() { truncate(GetTemporaryFilePath(), 16); };
ExpectRealtimeDeath(Func, MAYBE_APPEND_64("truncate"));
ExpectNonRealtimeSurvival(Func);
}

TEST_F(RtsanOpenedFileTest, FtruncateDiesWhenRealtime) {
auto Func = [&]() { ftruncate(GetOpenFd(), 16); };
ExpectRealtimeDeath(Func, MAYBE_APPEND_64("ftruncate"));
ExpectNonRealtimeSurvival(Func);
}

TEST_F(RtsanFileTest, FcloseDiesWhenRealtime) {
FILE *f = fopen(GetTemporaryFilePath(), "w");
EXPECT_THAT(f, Ne(nullptr));
Expand Down