Skip to content

[Clang] use parameter location for abbreviated function templates #129139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
a-tarasyuk merged 2 commits into from
Mar 6, 2025
Merged

[Clang] use parameter location for abbreviated function templates #129139

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ae7fe2
[Clang] use parameter location for abbreviated function templates
a-tarasyuk Feb 27, 2025
e4c4c83
use location from first param
a-tarasyuk Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions clang/docs/ReleaseNotes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,7 @@ Bug Fixes to C++ Support
- The initialization kind of elements of structured bindings
direct-list-initialized from an array is corrected to direct-initialization.
- Clang no longer crashes when a coroutine is declared ``[[noreturn]]``. (#GH127327)
- Clang now uses the parameter location for abbreviated function templates in ``extern "C"``. (#GH46386)

Bug Fixes to AST Handling
^^^^^^^^^^^^^^^^^^^^^^^^^
Expand Down
8 changes: 6 additions & 2 deletions clang/lib/Sema/SemaTemplate.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7991,8 +7991,12 @@ Sema::CheckTemplateDeclScope(Scope *S, TemplateParameterList *TemplateParams) {
// have C linkage.
DeclContext *Ctx = S->getEntity();
if (Ctx && Ctx->isExternCContext()) {
Diag(TemplateParams->getTemplateLoc(), diag::err_template_linkage)
<< TemplateParams->getSourceRange();
SourceRange Range =
TemplateParams->getTemplateLoc().isInvalid() && TemplateParams->size()
? TemplateParams->getParam(TemplateParams->size() - 1)
->getSourceRange()
: TemplateParams->getSourceRange();
Diag(Range.getBegin(), diag::err_template_linkage) << Range;
if (const LinkageSpecDecl *LSD = Ctx->getExternCContext())
Diag(LSD->getExternLoc(), diag::note_extern_c_begins_here);
return true;
Expand Down
15 changes: 15 additions & 0 deletions clang/test/CXX/temp/temp.pre/p6.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,19 @@
// RUN: %clang_cc1 -std=c++20 -verify %s
// RUN: not %clang_cc1 -std=c++20 -fsyntax-only -fno-diagnostics-show-line-numbers -fcaret-diagnostics-max-lines=1 %s 2>&1 | FileCheck %s -strict-whitespace

namespace GH46386 {
extern "C" { // expected-note {{extern "C" language linkage specification begins here}}

// CHECK: error: templates must have C++ linkage
// CHECK-NEXT: {{^}} void f(auto) {}
// CHECK-NEXT: {{^}} ^~~~~{{$}}
void f(auto) {} // expected-error {{templates must have C++ linkage}}

void f(void) { // expected-note {{candidate function not viable: requires 0 arguments, but 1 was provided}}
f(1); // expected-error {{no matching function for call to 'f'}}
}
}
}

// Templates and partial and explicit specializations can't have C linkage.
namespace extern_c_templates {
Expand Down