[libcxx] Export directory_iterator in module build #129195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is workaround for the link error like https://crbug.com/390537876.
llvmbot
added
the
libc++
Member
|
@llvm/pr-subscribers-libcxx Author: Takuto Ikuta (atetubou) ChangesThis is workaround for the link error like https://crbug.com/390537876. Might be related to #120108 too. Full diff: https://github.com/llvm/llvm-project/pull/129195.diff 1 Files Affected:
diff --git a/libcxx/include/module.modulemap b/libcxx/include/module.modulemap
index 0f2016e7f5d15..f94b6fc519399 100644
--- a/libcxx/include/module.modulemap
+++ b/libcxx/include/module.modulemap
@@ -1229,7 +1229,11 @@ module std [system] {
module filesystem {
module copy_options { header "__filesystem/copy_options.h" }
module directory_entry { header "__filesystem/directory_entry.h" }
- module directory_iterator { header "__filesystem/directory_iterator.h" }
+ module directory_iterator {
+ header "__filesystem/directory_iterator.h"
+ // This is a workaround for https://github.com/llvm/llvm-project/issues/120108.
+ export *
+ }
module directory_options { header "__filesystem/directory_options.h" }
module file_status { header "__filesystem/file_status.h" }
module file_time_type { header "__filesystem/file_time_type.h" }
|
mordante
reviewed
Mar 1, 2025
Contributor
Author
|
Thank you for review, can I ask you to merge this? |
Member
Thanks for patch! I've just landed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is workaround for the link error like https://crbug.com/390537876.
Might be related to #120108 too.