Skip to content

[clang] Remove isOSWindows() checks #129909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

[clang] Remove isOSWindows() checks #129909

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a41ed14
[clang] Remove isOSWindows() checks
Prabhuk Mar 5, 2025
34db4ba
Merge branch 'main' into clang_cleanup_1
Prabhuk Mar 10, 2025
fe37160
Use mangling scheme info from TargetInfo.
Prabhuk Mar 10, 2025
f86a3dd
Add mingw and uefi tests for varargs.
Prabhuk Mar 10, 2025
2ad7a50
Make shouldUseMicrosoftCCforMangling generic to be used for ABI decis…
Prabhuk Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions clang/lib/Sema/SemaChecking.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4769,31 +4769,32 @@ ExprResult Sema::CheckOSLogFormatStringArg(Expr *Arg) {
/// Check that the user is calling the appropriate va_start builtin for the
/// target and calling convention.
static bool checkVAStartABI(Sema &S, unsigned BuiltinID, Expr *Fn) {
const llvm::Triple &TT = S.Context.getTargetInfo().getTriple();
const TargetInfo &TI = S.Context.getTargetInfo();
bool IsMicrosoftABI = TI.getCXXABI().isMicrosoft();
const llvm::Triple &TT = TI.getTriple();
bool IsX64 = TT.getArch() == llvm::Triple::x86_64;
bool IsAArch64 = (TT.getArch() == llvm::Triple::aarch64 ||
TT.getArch() == llvm::Triple::aarch64_32);
bool IsWindows = TT.isOSWindows();
bool IsMSVAStart = BuiltinID == Builtin::BI__builtin_ms_va_start;
if (IsX64 || IsAArch64) {
CallingConv CC = CC_C;
if (const FunctionDecl *FD = S.getCurFunctionDecl())
CC = FD->getType()->castAs<FunctionType>()->getCallConv();
if (IsMSVAStart) {
// Don't allow this in System V ABI functions.
if (CC == CC_X86_64SysV || (!IsWindows && CC != CC_Win64))
if (CC == CC_X86_64SysV || (!IsMicrosoftABI && CC != CC_Win64))
return S.Diag(Fn->getBeginLoc(),
diag::err_ms_va_start_used_in_sysv_function);
} else {
// On x86-64/AArch64 Unix, don't allow this in Win64 ABI functions.
// On x64 Windows, don't allow this in System V ABI functions.
// (Yes, that means there's no corresponding way to support variadic
// System V ABI functions on Windows.)
if ((IsWindows && CC == CC_X86_64SysV) ||
(!IsWindows && CC == CC_Win64))
if ((IsMicrosoftABI && CC == CC_X86_64SysV) ||
(!IsMicrosoftABI && CC == CC_Win64))
return S.Diag(Fn->getBeginLoc(),
diag::err_va_start_used_in_wrong_abi_function)
<< !IsWindows;
<< !IsMicrosoftABI;
}
return false;
}
Expand Down