From 71f505219c0b1b8c0c6f5a9a966c954e6c9bc91d Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Wed, 5 Mar 2025 22:25:44 +0000 Subject: [PATCH] [Github][libc++] Prefer ubuntu-24.04 over ubuntu-latest This patch replaces all instances of ubuntu-latest with ubuntu-24.04 based on the guidelines in the LLVM CI best practices doc (https://llvm.org/docs/CIBestPractices.html). --- .github/workflows/libcxx-build-containers.yml | 2 +- .github/workflows/libcxx-check-generated-files.yml | 2 +- .github/workflows/libcxx-restart-preempted-jobs.yaml | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/libcxx-build-containers.yml b/.github/workflows/libcxx-build-containers.yml index bb4bd8843772f..b499af943c8e7 100644 --- a/.github/workflows/libcxx-build-containers.yml +++ b/.github/workflows/libcxx-build-containers.yml @@ -26,7 +26,7 @@ on: jobs: build-and-push: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 if: github.repository_owner == 'llvm' permissions: packages: write diff --git a/.github/workflows/libcxx-check-generated-files.yml b/.github/workflows/libcxx-check-generated-files.yml index 570055624b2a8..1f8103a114b9f 100644 --- a/.github/workflows/libcxx-check-generated-files.yml +++ b/.github/workflows/libcxx-check-generated-files.yml @@ -9,7 +9,7 @@ permissions: jobs: check_generated_files: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 steps: - name: Fetch LLVM sources uses: actions/checkout@v4 diff --git a/.github/workflows/libcxx-restart-preempted-jobs.yaml b/.github/workflows/libcxx-restart-preempted-jobs.yaml index e7e3772d4de22..7b341d7f22e41 100644 --- a/.github/workflows/libcxx-restart-preempted-jobs.yaml +++ b/.github/workflows/libcxx-restart-preempted-jobs.yaml @@ -26,7 +26,7 @@ jobs: statuses: read checks: write actions: write - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 steps: - name: "Restart Job" uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea #v7.0.1 @@ -161,7 +161,7 @@ jobs: statuses: read checks: write actions: write - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 steps: - name: "Restart Job (test)" uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea #v7.0.1