[mlir][tosa] Update ConstOp to use Tosa_Tensor #129959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we already defined Tosa_Tensor in TosaTypesBase.td, updated ConstOp to use that. Signed-off-by: Jerry Ge <[email protected]> Change-Id: If452150c05c0d7368e8c429ae074c3f0f27f77f0
Member
|
@llvm/pr-subscribers-mlir Author: Jerry-Ge (Jerry-Ge) ChangesSince we already defined Tosa_Tensor in TosaTypesBase.td, updated ConstOp to use that. Full diff: https://github.com/llvm/llvm-project/pull/129959.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td b/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td
index ff83e4072b6c0..61178a0110aa3 100644
--- a/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td
+++ b/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td
@@ -2359,7 +2359,7 @@ def Tosa_ConstOp : Tosa_Op<"const", [ConstantLike, Pure,
);
let results = (outs
- TosaTensorOf<[AnyTypeOf<[Tosa_AnyNumber]>]>:$output
+ Tosa_Tensor:$output
);
list<Availability> availability = [
|
Member
|
@llvm/pr-subscribers-mlir-tosa Author: Jerry-Ge (Jerry-Ge) ChangesSince we already defined Tosa_Tensor in TosaTypesBase.td, updated ConstOp to use that. Full diff: https://github.com/llvm/llvm-project/pull/129959.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td b/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td
index ff83e4072b6c0..61178a0110aa3 100644
--- a/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td
+++ b/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td
@@ -2359,7 +2359,7 @@ def Tosa_ConstOp : Tosa_Op<"const", [ConstantLike, Pure,
);
let results = (outs
- TosaTensorOf<[AnyTypeOf<[Tosa_AnyNumber]>]>:$output
+ Tosa_Tensor:$output
);
list<Availability> availability = [
|
GeorgeARM
approved these changes
Mar 6, 2025
lhutton1
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we already defined Tosa_Tensor in TosaTypesBase.td, updated ConstOp to use that.