Skip to content

[MLIR][LLVMIR] Translation: honor frame-pointer fn attribute #130335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 8, 2025
Merged

[MLIR][LLVMIR] Translation: honor frame-pointer fn attribute #130335

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d97fa7
[MLIR][LLVMIR] Translation: honor frame-pointer fn attribute
bcardosolopes Mar 7, 2025
ea3e625
Add more comments
bcardosolopes Mar 7, 2025
e85ff75
Remove redundanct frame-pointer
bcardosolopes Mar 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1606,6 +1606,9 @@ static void convertFunctionAttributes(LLVMFuncOp func,
llvmFunc->addFnAttr(llvm::Attribute::NoUnwind);
if (func.getWillReturnAttr())
llvmFunc->addFnAttr(llvm::Attribute::WillReturn);
if (FramePointerKindAttr fpAttr = func.getFramePointerAttr())
llvmFunc->addFnAttr("frame-pointer", stringifyFramePointerKind(
fpAttr.getFramePointerKind()));
convertFunctionMemoryAttributes(func, llvmFunc);
}

Expand Down
12 changes: 12 additions & 0 deletions mlir/test/Target/LLVMIR/llvmir.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2454,6 +2454,18 @@ llvm.func @preserves_za_func() attributes {arm_preserves_za} {

// -----

//
// frame pointer attribute.
//

// CHECK-LABEL: @t
// CHECK-SAME: #[[FP:.*]]
llvm.func @t(!llvm.ptr) attributes {frame_pointer = #llvm.framePointerKind<"non-leaf">}

// CHECK: attributes #[[FP]] = { "frame-pointer"="non-leaf" }

// -----

//
// Zero-initialize operation.
//
Expand Down