diff --git a/mlir/lib/Dialect/MemRef/Transforms/RuntimeOpVerification.cpp b/mlir/lib/Dialect/MemRef/Transforms/RuntimeOpVerification.cpp index cd92026562da9..2e97fafdceace 100644 --- a/mlir/lib/Dialect/MemRef/Transforms/RuntimeOpVerification.cpp +++ b/mlir/lib/Dialect/MemRef/Transforms/RuntimeOpVerification.cpp @@ -426,10 +426,13 @@ void mlir::memref::registerRuntimeVerifiableOpInterfaceExternalModels( DialectRegistry ®istry) { registry.addExtension(+[](MLIRContext *ctx, memref::MemRefDialect *dialect) { AssumeAlignmentOp::attachInterface(*ctx); + AtomicRMWOp::attachInterface>(*ctx); CastOp::attachInterface(*ctx); CopyOp::attachInterface(*ctx); DimOp::attachInterface(*ctx); ExpandShapeOp::attachInterface(*ctx); + GenericAtomicRMWOp::attachInterface< + LoadStoreOpInterface>(*ctx); LoadOp::attachInterface>(*ctx); ReinterpretCastOp::attachInterface(*ctx); StoreOp::attachInterface>(*ctx); diff --git a/mlir/test/Integration/Dialect/MemRef/atomic-rmw-runtime-verification.mlir b/mlir/test/Integration/Dialect/MemRef/atomic-rmw-runtime-verification.mlir new file mode 100644 index 0000000000000..26c731c921356 --- /dev/null +++ b/mlir/test/Integration/Dialect/MemRef/atomic-rmw-runtime-verification.mlir @@ -0,0 +1,43 @@ +// RUN: mlir-opt %s -generate-runtime-verification \ +// RUN: -test-cf-assert \ +// RUN: -convert-to-llvm | \ +// RUN: mlir-runner -e main -entry-point-result=void \ +// RUN: -shared-libs=%mlir_runner_utils 2>&1 | \ +// RUN: FileCheck %s + +func.func @store_dynamic(%memref: memref, %index: index) { + %cst = arith.constant 1.0 : f32 + memref.atomic_rmw addf %cst, %memref[%index] : (f32, memref) -> f32 + return +} + +func.func @main() { + // Allocate a memref<10xf32>, but disguise it as a memref<5xf32>. This is + // necessary because "-test-cf-assert" does not abort the program and we do + // not want to segfault when running the test case. + %alloc = memref.alloca() : memref<10xf32> + %ptr = memref.extract_aligned_pointer_as_index %alloc : memref<10xf32> -> index + %ptr_i64 = arith.index_cast %ptr : index to i64 + %ptr_llvm = llvm.inttoptr %ptr_i64 : i64 to !llvm.ptr + %c0 = llvm.mlir.constant(0 : index) : i64 + %c1 = llvm.mlir.constant(1 : index) : i64 + %c5 = llvm.mlir.constant(5 : index) : i64 + %4 = llvm.mlir.poison : !llvm.struct<(ptr, ptr, i64, array<1 x i64>, array<1 x i64>)> + %5 = llvm.insertvalue %ptr_llvm, %4[0] : !llvm.struct<(ptr, ptr, i64, array<1 x i64>, array<1 x i64>)> + %6 = llvm.insertvalue %ptr_llvm, %5[1] : !llvm.struct<(ptr, ptr, i64, array<1 x i64>, array<1 x i64>)> + %8 = llvm.insertvalue %c0, %6[2] : !llvm.struct<(ptr, ptr, i64, array<1 x i64>, array<1 x i64>)> + %9 = llvm.insertvalue %c5, %8[3, 0] : !llvm.struct<(ptr, ptr, i64, array<1 x i64>, array<1 x i64>)> + %10 = llvm.insertvalue %c1, %9[4, 0] : !llvm.struct<(ptr, ptr, i64, array<1 x i64>, array<1 x i64>)> + %buffer = builtin.unrealized_conversion_cast %10 : !llvm.struct<(ptr, ptr, i64, array<1 x i64>, array<1 x i64>)> to memref<5xf32> + %cast = memref.cast %buffer : memref<5xf32> to memref + + // CHECK: ERROR: Runtime op verification failed + // CHECK-NEXT: "memref.atomic_rmw"(%{{.*}}, %{{.*}}, %{{.*}}) <{kind = 0 : i64}> : (f32, memref, index) -> f32 + // CHECK-NEXT: ^ out-of-bounds access + // CHECK-NEXT: Location: loc({{.*}}) + %c9 = arith.constant 9 : index + func.call @store_dynamic(%cast, %c9) : (memref, index) -> () + + return +} + diff --git a/mlir/test/Integration/Dialect/MemRef/store-runtime-verification.mlir b/mlir/test/Integration/Dialect/MemRef/store-runtime-verification.mlir new file mode 100644 index 0000000000000..12253fa3b5e83 --- /dev/null +++ b/mlir/test/Integration/Dialect/MemRef/store-runtime-verification.mlir @@ -0,0 +1,43 @@ +// RUN: mlir-opt %s -generate-runtime-verification \ +// RUN: -test-cf-assert \ +// RUN: -convert-to-llvm | \ +// RUN: mlir-runner -e main -entry-point-result=void \ +// RUN: -shared-libs=%mlir_runner_utils 2>&1 | \ +// RUN: FileCheck %s + +func.func @store_dynamic(%memref: memref, %index: index) { + %cst = arith.constant 1.0 : f32 + memref.store %cst, %memref[%index] : memref + return +} + +func.func @main() { + // Allocate a memref<10xf32>, but disguise it as a memref<5xf32>. This is + // necessary because "-test-cf-assert" does not abort the program and we do + // not want to segfault when running the test case. + %alloc = memref.alloca() : memref<10xf32> + %ptr = memref.extract_aligned_pointer_as_index %alloc : memref<10xf32> -> index + %ptr_i64 = arith.index_cast %ptr : index to i64 + %ptr_llvm = llvm.inttoptr %ptr_i64 : i64 to !llvm.ptr + %c0 = llvm.mlir.constant(0 : index) : i64 + %c1 = llvm.mlir.constant(1 : index) : i64 + %c5 = llvm.mlir.constant(5 : index) : i64 + %4 = llvm.mlir.poison : !llvm.struct<(ptr, ptr, i64, array<1 x i64>, array<1 x i64>)> + %5 = llvm.insertvalue %ptr_llvm, %4[0] : !llvm.struct<(ptr, ptr, i64, array<1 x i64>, array<1 x i64>)> + %6 = llvm.insertvalue %ptr_llvm, %5[1] : !llvm.struct<(ptr, ptr, i64, array<1 x i64>, array<1 x i64>)> + %8 = llvm.insertvalue %c0, %6[2] : !llvm.struct<(ptr, ptr, i64, array<1 x i64>, array<1 x i64>)> + %9 = llvm.insertvalue %c5, %8[3, 0] : !llvm.struct<(ptr, ptr, i64, array<1 x i64>, array<1 x i64>)> + %10 = llvm.insertvalue %c1, %9[4, 0] : !llvm.struct<(ptr, ptr, i64, array<1 x i64>, array<1 x i64>)> + %buffer = builtin.unrealized_conversion_cast %10 : !llvm.struct<(ptr, ptr, i64, array<1 x i64>, array<1 x i64>)> to memref<5xf32> + %cast = memref.cast %buffer : memref<5xf32> to memref + + // CHECK: ERROR: Runtime op verification failed + // CHECK-NEXT: "memref.store"(%{{.*}}, %{{.*}}, %{{.*}}) : (f32, memref, index) -> () + // CHECK-NEXT: ^ out-of-bounds access + // CHECK-NEXT: Location: loc({{.*}}) + %c9 = arith.constant 9 : index + func.call @store_dynamic(%cast, %c9) : (memref, index) -> () + + return +} +