Skip to content

[ADT] Add DenseSet::insert_range #131567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2025
Merged

[ADT] Add DenseSet::insert_range #131567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88a4372
[ADT] Add DenseSet::insert_range
kazutakahirata Mar 17, 2025
e6157a1
Address a comment.
kazutakahirata Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions llvm/include/llvm/ADT/DenseSet.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
#ifndef LLVM_ADT_DENSESET_H
#define LLVM_ADT_DENSESET_H

#include "llvm/ADT/ADL.h"
#include "llvm/ADT/DenseMap.h"
#include "llvm/ADT/DenseMapInfo.h"
#include "llvm/Support/MathExtras.h"
Expand Down Expand Up @@ -237,6 +238,10 @@ class DenseSetImpl {
for (; I != E; ++I)
insert(*I);
}

template <typename Range> void insert_range(Range &&R) {
insert(adl_begin(R), adl_end(R));
}
};

/// Equality comparison for DenseSet.
Expand Down
8 changes: 8 additions & 0 deletions llvm/unittests/ADT/DenseSetTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
//===----------------------------------------------------------------------===//

#include "llvm/ADT/DenseSet.h"
#include "gmock/gmock.h"
#include "gtest/gtest.h"
#include <type_traits>

Expand All @@ -32,6 +33,13 @@ TEST(DenseSetTest, DoubleEntrySetTest) {
EXPECT_EQ(0u, set.count(2));
}

TEST(DenseSetTest, InsertRange) {
llvm::DenseSet<unsigned> set;
constexpr unsigned Args[] = {3, 1, 2};
set.insert_range(Args);
EXPECT_THAT(set, ::testing::UnorderedElementsAre(1, 2, 3));
}

struct TestDenseSetInfo {
static inline unsigned getEmptyKey() { return ~0; }
static inline unsigned getTombstoneKey() { return ~0U - 1; }
Expand Down