Skip to content

[JSON][NFC] Move print method out of NDEBUG || DUMP #131639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2025
Merged

[JSON][NFC] Move print method out of NDEBUG || DUMP #131639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm/include/llvm/Support/JSON.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,8 +472,8 @@ class Value {
return LLVM_LIKELY(Type == T_Array) ? &as<json::Array>() : nullptr;
}

#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
void print(llvm::raw_ostream &OS) const;
#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
LLVM_DUMP_METHOD void dump() const {
print(llvm::dbgs());
llvm::dbgs() << '\n';
Expand Down
2 changes: 0 additions & 2 deletions llvm/lib/Support/JSON.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,9 +182,7 @@ void Value::destroy() {
}
}

#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
void Value::print(llvm::raw_ostream &OS) const { OS << *this; }
#endif // !NDEBUG || LLVM_ENABLE_DUMP

bool operator==(const Value &L, const Value &R) {
if (L.kind() != R.kind())
Expand Down