[debuginfo-tests] Use built lldb for testing if available #131681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@JDevlieghere I imagine there's a better way of doing this, but I couldn't figure out what the right way would be. Any ideas? |
|
✅ With the latest revision this PR passed the Python code formatter. |
The cross-project-tests's debuginfo-tests don't rely on lldb being built to run. While this is a good, a bug in the system lldb can cause a test to fail with no way of fixing it. This patch makes it so the tests use the built lldb instead if it's available.
augusto2112
force-pushed
the
cross-project-built-lldb
branch
from
07c2b44 to
b785ad6
Compare
| command="LLVM_LIBS_DIR=" | ||
| + config.llvm_libs_dir | ||
| + " " | ||
| + os.path.join( |
Collaborator
There was a problem hiding this comment.
why don't we pass in the right python executable and the full path to the LLDB python packages here, then there doesn't need to be any guesswork in the other two files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cross-project-tests's debuginfo-tests don't rely on lldb being built to run. While this is a good, a bug in the system lldb can cause a test to fail with no way of fixing it. This patch makes it so the tests use the built lldb instead if it's available.