Skip to content

[clang] Fix crash on invalid std::initializer_list<T> template-id #132284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 1, 2025
Merged

[clang] Fix crash on invalid std::initializer_list<T> template-id #132284

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
553ced1
[clang] Fix crash on invalid `std::initializer_list<T>` template-id
offsetof Mar 20, 2025
bd5c32e
fixup! [clang] Fix crash on invalid `std::initializer_list<T>` templa…
offsetof Mar 24, 2025
a501965
Merge branch 'main' into issue132256
offsetof Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions clang/lib/Sema/SemaDeclCXX.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12182,10 +12182,14 @@ QualType Sema::BuildStdInitializerList(QualType Element, SourceLocation Loc) {
Args.addArgument(TemplateArgumentLoc(TemplateArgument(Element),
Context.getTrivialTypeSourceInfo(Element,
Loc)));

QualType T = CheckTemplateIdType(TemplateName(StdInitializerList), Loc, Args);
Copy link
Contributor

@ojhunt ojhunt Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably keep this as an additional sanity check, however I think in this particular case the error is in the validity check in LookupStdInitializerList, where it is checking the minimum required template parameters, rather than ensuring real correctness.

It should probably be doing Params->size() != 1, and ensuring that there isn't a parameter pack or any default template arguments.

Changing those validity checks will also result in a much more direct error saying std::initializer_list is defined incorrectly.

Copy link
Contributor Author

@offsetof offsetof Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened a separate PR for this change: #133822

if (T.isNull())
return QualType();

return Context.getElaboratedType(
ElaboratedTypeKeyword::None,
NestedNameSpecifier::Create(Context, nullptr, getStdNamespace()),
CheckTemplateIdType(TemplateName(StdInitializerList), Loc, Args));
NestedNameSpecifier::Create(Context, nullptr, getStdNamespace()), T);
}

bool Sema::isInitListConstructor(const FunctionDecl *Ctor) {
Expand Down
14 changes: 14 additions & 0 deletions clang/test/SemaCXX/invalid-std-initializer-list.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
// RUN: %clang_cc1 %s -verify -std=c++20

namespace std {

template<class T, class = T::x> // expected-error 2 {{type 'int' cannot be used prior to '::' because it has no members}}
class initializer_list;

}

auto x = {1}; // expected-note {{in instantiation of default argument for 'initializer_list<int>' required here}}

void f() {
for(int x : {1, 2}); // expected-note {{in instantiation of default argument for 'initializer_list<int>' required here}}
}
Comment on lines +11 to +16
Copy link
Contributor

@zyn0217 zyn0217 Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually wrap the test with a namespace of its corresponding GH number.

Copy link
Contributor Author

@offsetof offsetof Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a namespace and a release note.