Skip to content

[SPIR-V] Don't add linkage attributes for input variables #132301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
s-perron merged 1 commit into from
Mar 21, 2025
Merged

[SPIR-V] Don't add linkage attributes for input variables #132301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3993,7 +3993,7 @@ bool SPIRVInstructionSelector::loadVec3BuiltinInputID(
// builtin variable.
Register Variable = GR.buildGlobalVariable(
NewRegister, PtrType, getLinkStringForBuiltIn(BuiltInValue), nullptr,
SPIRV::StorageClass::Input, nullptr, true, true,
SPIRV::StorageClass::Input, nullptr, true, false,
SPIRV::LinkageType::Import, MIRBuilder, false);

// Create new register for loading value.
Expand Down Expand Up @@ -4046,7 +4046,7 @@ bool SPIRVInstructionSelector::loadBuiltinInputID(
// builtin variable.
Register Variable = GR.buildGlobalVariable(
NewRegister, PtrType, getLinkStringForBuiltIn(BuiltInValue), nullptr,
SPIRV::StorageClass::Input, nullptr, true, true,
SPIRV::StorageClass::Input, nullptr, true, false,
SPIRV::LinkageType::Import, MIRBuilder, false);

// Load uint value from the global variable.
Expand Down
1 change: 0 additions & 1 deletion llvm/test/CodeGen/SPIRV/hlsl-intrinsics/SV_DispatchThreadID.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

; CHECK-DAG: OpEntryPoint GLCompute {{.*}} %[[#GlobalInvocationId]]
; CHECK-DAG: OpName %[[#GlobalInvocationId]] "__spirv_BuiltInGlobalInvocationId"
; CHECK-DAG: OpDecorate %[[#GlobalInvocationId]] LinkageAttributes "__spirv_BuiltInGlobalInvocationId" Import
; CHECK-DAG: OpDecorate %[[#GlobalInvocationId]] BuiltIn GlobalInvocationId

; ModuleID = '-'
Expand Down
1 change: 0 additions & 1 deletion llvm/test/CodeGen/SPIRV/hlsl-intrinsics/SV_GroupID.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

; CHECK-DAG: OpEntryPoint GLCompute {{.*}} %[[#WorkgroupId]]
; CHECK-DAG: OpName %[[#WorkgroupId]] "__spirv_BuiltInWorkgroupId"
; CHECK-DAG: OpDecorate %[[#WorkgroupId]] LinkageAttributes "__spirv_BuiltInWorkgroupId" Import
; CHECK-DAG: OpDecorate %[[#WorkgroupId]] BuiltIn WorkgroupId

target triple = "spirv-unknown-vulkan-library"
Expand Down
1 change: 0 additions & 1 deletion llvm/test/CodeGen/SPIRV/hlsl-intrinsics/SV_GroupThreadID.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

; CHECK-DAG: OpEntryPoint GLCompute {{.*}} %[[#LocalInvocationId]]
; CHECK-DAG: OpName %[[#LocalInvocationId]] "__spirv_BuiltInLocalInvocationId"
; CHECK-DAG: OpDecorate %[[#LocalInvocationId]] LinkageAttributes "__spirv_BuiltInLocalInvocationId" Import
; CHECK-DAG: OpDecorate %[[#LocalInvocationId]] BuiltIn LocalInvocationId

; ModuleID = '-'
Expand Down